Greatly improve the understanding of the log-potential-typedef-remappings feature
#281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, this improves the
log-potential-typedef-remappingsfeature. In particular we now actually track found typedefs and compare that against given remappings; suggesting a "preferred" remapping using the existing heuristics if one exists and always listing the alternative remappings that were found.Users can still override this behavior by prefixing the remapped name with
@. For exampleIID_XMLDSOControl=@CLSID_XMLDSOControl. This allows you to override the naming without worrying about warnings still being raised.