Ensure that the record packing and calling convention are correct regardless of -m32 or -m64 #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
force-pushed
the
main
branch
2 times, most recently
from
8602964 to
e0e1e04
Compare
…ardless of -m32 or -m64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #233
ClangSharpPInvokeGenerator was attempting to be "smart" by calculating the alignment itself, but this is potentially problematic for scenarios that differ between 32-bit and 64-bit as the Clang AST will only expose one.
This updates the generator to check for and use the attribute added to records that are under a
#pragma packdirective and rely on that if it exists. This avoids issues like in #233 that were arising when a struct contained pointer types and was#pragma pack 4(which meant "expected packing matches specified packing", when in actuality it differed for 64-bit targets).