Adding test coverage for the XML generator #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
reviewed
Mar 21, 2021
| var needsReturnFixup = isVirtual && NeedsReturnFixup(cxxMethodDecl); | ||
|
|
||
| if (!(functionDecl is CXXConstructorDecl)) | ||
| if ((functionDecl is not CXXConstructorDecl) || (_config.OutputMode == PInvokeGeneratorOutputMode.Xml)) |
There was a problem hiding this comment.
I guess we should add a boolean to WriteReturnType indicating whether it's for a ctor or not to avoid this being baked into VisitDecl, that does nothing if that boolean is true on the C# backend.
| return ValidateGeneratedXmlCompatibleUnixBindingsAsync(inputContents, expectedOutputContents); | ||
| } | ||
|
|
||
| public override Task NewKeywordTest() |
There was a problem hiding this comment.
I suppose this test is a bit redundant given we expect the downstream consumer to determine whether a new keyword is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.