chore: Simplify job display name presentation when using DontEnforcePowerPlan #2963
+35
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
force-pushed
the
chore-simplify-job-presentation
branch
3 times, most recently
from
08cd83a to
ca3d2ab
Compare
filzrev
force-pushed
the
chore-simplify-job-presentation
branch
from
ca3d2ab to
cbdda3f
Compare
filzrev
force-pushed
the
chore-simplify-job-presentation
branch
from
ffe0460 to
1a1872a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
DontEnforcePowerPlan.Guid.Emptyvalue is set toPowerPlanModeCharacteristicand Guid.Empty value is displayed as Job display name as following.This PR intended to remove redundant text
PowerPlanMode=00000000-0000-0000-0000-000000000000from job display name.What's changed by this PR**
CharacteristicPresenter.csAdd logics to return empty string when PowerPlanModeCharacteristic value is
Guid.Empty.CharacteristicSetPresenter.csAdd code to exclude null or empty string from returned characteristic values.