-
-
Notifications
You must be signed in to change notification settings - Fork 1k
[Feature] In-process diagnosers #2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e97b525 to
34ed698
Compare
Make DisassemblyDiagnoser run in-process by default. Revert x86 test workaround and add tests.
83912f1 to
3ad6a27
Compare
|
It works nicely, but I'm not entirely sold on this design of diagnosers creating source code tied to C#. An alternative is serializing ctor data. I would love to use static interface members for this, but sadly they aren't supported on netstandard2.0. 😞 @AndreyAkinshin Any thoughts? |
|
@adamsitnik could you please take a look? |
|
I changed it so diagnosers return Type and serialized config instead of source code. I think source code generation should be left to the toolchains. |
ef14209 to
eb27f66
Compare
IInProcessDiagnoserinterface.DisassemblyDiagnoseris the first in-process diagnoser (with the option to run in host for back-compat).test-windows-fullCI job failed on disassemble tests for x86 #2789