Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Apr 27, 2025

This PR intended to fix #2721

What's changed in this PR

  1. Add DisableParallelBuild flag to ConfigOptions.
  2. Modify BenchmarkRunnerClean::Run.
    2.1. Add BuildSequential method that build project in sequentially.
    2.2. Add logics to check DisableParallelBuild option. If any of benchmarks contains DisableParallelBuild flag. Use sequential build path instead of parallel build path.

Test
I've manually confirmed that sequential build path is called when specifying WithOptions(ConfigOptions.DisableParallelBuild); on benchmark config.

@timcassell
Copy link
Collaborator

@AndreyAkinshin @adamsitnik It's ok to use ConfigOptions enum for this? Or another method is preferred?

@timcassell timcassell requested a review from AndreyAkinshin May 1, 2025 23:35
@timcassell timcassell mentioned this pull request May 2, 2025
@AndreyAkinshin
Copy link
Member

It's ok to use ConfigOptions enum for this?

@timcassell it's OK

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like MacOS integration tests are failing by timeout on the WasmIsSupported test. It's unrelated to these changes.

Thanks @filzrev!

@timcassell timcassell merged commit ee248c3 into dotnet:master May 3, 2025
7 of 8 checks passed
@timcassell timcassell added this to the v0.14.1 milestone May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add options to disable build in parallel.

3 participants