Always fail if dotnet command failed #2535
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamsitnik PTAL |
This was referenced Jan 6, 2025
|
The "the exit code might be 1 due to warnings" seems like something that might be worth keeping, maybe limit it to certain ranges of exit codes, or add some sort of command line switch like '--ignoreexitcode' so that people who were relying on the old behavior aren't stuck? |
|
I don't know the specifics around exit code 1 for warnings, but that file is quite old, so I'm thinking that may have only been an issue with early Core sdks (which we no longer support). I wasn't able to get that result with latest sdk. |
AndreyAkinshin
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2533