[NativeAOT] use PublishAot and don't reference ILCompiler in explicit way #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
approved these changes
Sep 5, 2022
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Sorry for the shuffles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent SDK changes the NativeAOT support got broken again. This time the failure was silent: since we were not setting
PublishAotto true, the published app was regular .NET app, not NativeAOT.This PR sets
PublishAottotrueand removes the explicit reference toILCompilerif it's specific version was not provided.I've tested:
@AndreyAkinshin we might need to release a new BDN version soon (preferably with #2092 merged as well)
cc @MichalStrehovsky