Restrict what's published to AppVeyor NuGet feed (BDN nightly) #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes cake build regression introduced by switching from the old cake script https://github.com/dotnet/BenchmarkDotNet/blob/a936815f2a58d9b728cfc5fe620bba17481c180c/build.cake#L151-L153 - and additionally excludes any builds triggered from commits to non-master branches. The Cake Pack task is executed only if the build: - runs on AppVeyor - is not a PR - is triggered from 'master' branch - runs on Windows Reason: On AppVeyor, the packages produced by Pack are automatically uploaded as artifacts AND to the AppVeyor NuGet feed. On GitHub and Azure Pipelines, Pack output is discarded anyway. Fixes dotnet#1937.
adamsitnik
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BenchmarkDotNet/build.cake
Lines 151 to 153 in a936815
The Cake Pack task is executed only if the build:
Reason:
On AppVeyor, the packages produced by Pack are automatically uploaded as artifacts AND to the AppVeyor NuGet feed.
On GitHub and Azure Pipelines, Pack output is discarded anyway.
Fixes #1937.