Skip to content

adjust defaultBenchmarkDotNetVersion on build #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 4, 2023
Merged

adjust defaultBenchmarkDotNetVersion on build #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ec4deb
adjust defaultBenchmarkDotNetVersion on build
askazakov Dec 30, 2021
c6bd682
fix https://github.com/dotnet/BenchmarkDotNet/pull/1879#discussion_r1…
askazakov Jul 4, 2023
4f7eac2
fix https://github.com/dotnet/BenchmarkDotNet/pull/1879#discussion_r1…
askazakov Jul 4, 2023
8ba62e2
fix https://github.com/dotnet/BenchmarkDotNet/pull/1879#discussion_r1…
askazakov Jul 4, 2023
09142e5
add install-from-source.sh (for macOS for example)
askazakov Jul 4, 2023
54026d2
fix copy paste
askazakov Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions build/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,28 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>

<UsingTask TaskName="ReplaceFileText"
TaskFactory="RoslynCodeTaskFactory"
AssemblyFile="$(MSBuildToolsPath)\Microsoft.Build.Tasks.Core.dll">
<ParameterGroup>
<InputFilename ParameterType="System.String" Required="true" />
<OutputFilename ParameterType="System.String" Required="true" />
<MatchExpression ParameterType="System.String" Required="true" />
<ReplacementText ParameterType="System.String" Required="true" />
</ParameterGroup>
<Task>
<Using Namespace="System" />
<Using Namespace="System.IO" />
<Using Namespace="System.Text.RegularExpressions" />
<Code Type="Fragment" Language="cs">
<![CDATA[
File.WriteAllText(
OutputFilename,
Regex.Replace(File.ReadAllText(InputFilename), MatchExpression, ReplacementText)
);
]]>
</Code>
</Task>
</UsingTask>
</Project>
21 changes: 21 additions & 0 deletions templates/BenchmarkDotNet.Templates.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,25 @@
<Compile Remove="**\*" />
<None Remove="*.bat;.sh" />
</ItemGroup>

<Target Name="Fix BenchmarkDotNetVersion"
BeforeTargets="Build">
<ReplaceFileText
InputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json"
OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json"
MatchExpression='("defaultValue": )"([\d+\.?]+)"'
ReplacementText='${1}"$(VersionPrefix)"' />

<ReplaceFileText
InputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.FSharp/.template.config/template.json"
OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.FSharp/.template.config/template.json"
MatchExpression='("defaultValue": )"([\d+\.?]+)"'
ReplacementText='${1}"$(VersionPrefix)"' />

<ReplaceFileText
InputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.VB/.template.config/template.json"
OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.VB/.template.config/template.json"
MatchExpression='("defaultValue": )"([\d+\.?]+)"'
ReplacementText='${1}"$(VersionPrefix)"' />
</Target>
</Project>
13 changes: 13 additions & 0 deletions templates/install-from-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Run only from the folder where the shell script is located!

dotnet build BenchmarkDotNet.Templates.csproj -c Release
dotnet pack BenchmarkDotNet.Templates.csproj -c Release

# If we install the templates via a folder path, then it will have a different ID (ID=folder path).
# It will conflict with BDN templates from nuget.
# We need to install the templates via a FILE path in order to update the template from nuget.

nupkg_path=$(find . -name "BenchmarkDotNet.Templates*.nupkg")

dotnet new uninstall "BenchmarkDotNet.Templates"
dotnet new install $nupkg_path