Skip to content

don't redirect Standard Error, as we don't read it and writing to it by benchmark can cause deadlocks #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 3 commits into from
Jan 20, 2021
Merged

don't redirect Standard Error, as we don't read it and writing to it by benchmark can cause deadlocks #1631

adamsitnik merged 3 commits into from
Jan 20, 2021

Conversation

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Jan 7, 2021

@adamsitnik adamsitnik added this to the v0.13.0 milestone Jan 7, 2021
@adamsitnik adamsitnik removed the bug label Jan 7, 2021
AndreyAkinshin
AndreyAkinshin approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsitnik adamsitnik merged commit 5b21673 into master Jan 20, 2021
@adamsitnik adamsitnik deleted the standardError branch January 20, 2021 16:16
@adamsitnik adamsitnik mentioned this pull request Jan 21, 2021
Closed
@YegorStepanov YegorStepanov mentioned this pull request Sep 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees

No one assigned

Labels

Area:Toolchains

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

Writing to Console.Error in benchmarked code causes a deadlock

3 participants

@adamsitnik @AndreyAkinshin