Support IEnumerable as benchmark argument #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawosoft
added a commit
to mawosoft/BenchmarkDotNet
that referenced
this pull request
Jul 17, 2022
SmartParameter codegen must use the target type for casting, not the type of the source value. Basically, this is a follow up to PR dotnet#1228 (1678a49), which fixed this problem for SmartArgument. Fixes dotnet#2011.
adamsitnik
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Bugfix SmartParameter source code generation SmartParameter codegen must use the target type for casting, not the type of the source value. Basically, this is a follow up to PR #1228 (1678a49), which fixed this problem for SmartArgument. Fixes #2011. * Tests added. * Applying code review suggestions; code clean-up. PR fixes the following issues: fixes #2011, fixes #1812, fixes #1177.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for bug reported by @stephentoub in dotnet/corefx#40377