Keep generated files when MSBuild bin log is requested (#2254)

dotnet · Feb 13, 2023 · d3fbc03 · d3fbc03
1 parent 615384d
commit d3fbc03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs b/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
@@ -250,6 +250,9 @@ private static IConfig CreateConfig(CommandLineOptions options, IConfig globalCo
             config.WithOption(ConfigOptions.ApplesToApples, options.ApplesToApples);
             config.WithOption(ConfigOptions.Resume, options.Resume);
 
+            if (config.Options.IsSet(ConfigOptions.GenerateMSBuildBinLog))
+                config.Options |= ConfigOptions.KeepBenchmarkFiles;
+
             if (options.MaxParameterColumnWidth.HasValue)
                 config.WithSummaryStyle(SummaryStyle.Default.WithMaxParameterColumnWidth(options.MaxParameterColumnWidth.Value));
 

diff --git a/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs b/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
@@ -291,7 +291,7 @@ public void DotNetCliParsedCorrectly(string tfm)
         [InlineData(ConfigOptions.StopOnFirstError, "--stopOnFirstError")]
         [InlineData(ConfigOptions.DisableLogFile, "--disableLogFile" )]
         [InlineData(ConfigOptions.LogBuildOutput, "--logBuildOutput")]
-        [InlineData(ConfigOptions.GenerateMSBuildBinLog, "--generateBinLog")]
+        [InlineData(ConfigOptions.GenerateMSBuildBinLog | ConfigOptions.KeepBenchmarkFiles, "--generateBinLog")]
         [InlineData(
             ConfigOptions.JoinSummary |
             ConfigOptions.KeepBenchmarkFiles |