Skip to content

Conversation

@Tratcher
Copy link
Member

@Tratcher Tratcher commented Sep 9, 2021

Fixes dotnet/aspnetcore#35204

Consider holding this update until RC1 releases.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 9, 2021

What about:

  <ItemGroup>
    <!-- Required for QUIC & HTTP/3 in .NET 6 - https://github.com/dotnet/runtime/pull/55332 -->
    <RuntimeHostConfigurationOption Include="System.Net.SocketsHttpHandler.Http3Support" Value="true" />
  </ItemGroup>

@Tratcher
Copy link
Member Author

Tratcher commented Sep 9, 2021

What about:

  <ItemGroup>
    <!-- Required for QUIC & HTTP/3 in .NET 6 - https://github.com/dotnet/runtime/pull/55332 -->
    <RuntimeHostConfigurationOption Include="System.Net.SocketsHttpHandler.Http3Support" Value="true" />
  </ItemGroup>

That's only required for HttpClient.

@Tratcher
Copy link
Member Author

Tratcher commented Sep 9, 2021

@Rick-Anderson the monikers need work. How should we handle them for 5.0 and 3.1?

Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rick-Anderson the monikers need work. How should we handle them for 5.0 and 3.1?

I can fork this and fix them. You can review my PR and merge into this branch. OR, I could just create a new PR with them fixed and all the content you have here. Your call.


## HTTP/3 support

[HTTP/3](https://quicwg.org/base-drafts/draft-ietf-quic-http.html) is enabled for ASP.NET Core apps if the following base requirements are met:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[HTTP/3](https://quicwg.org/base-drafts/draft-ietf-quic-http.html) is enabled for ASP.NET Core apps if the following base requirements are met:
[HTTP/3](https://quicwg.org/base-drafts/draft-ietf-quic-http.html) is enabled for ASP.NET Core apps when the following base requirements are met:

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson the monikers need work. How should we handle them for 5.0 and 3.1?

I should probably make a RC1 branch and when this is finished, merge to RC1. At RC1, we can merge the RC1 branch into main.

@Tratcher
Copy link
Member Author

Tratcher commented Sep 9, 2021

@Rick-Anderson the monikers need work. How should we handle them for 5.0 and 3.1?

I can fork this and fix them. You can review my PR and merge into this branch. OR, I could just create a new PR with them fixed and all the content you have here. Your call.

Whatever's easier for you.

@Rick-Anderson
Copy link
Contributor

@Tratcher I can always prepare the ::: moniker range=">= aspnetcore-6.0" section for you.

@Rick-Anderson
Copy link
Contributor

moved to #23257

@Tratcher Tratcher deleted the tratcher/h3/httpsys branch September 14, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docs for using HTTP/3 with HTTP.sys

4 participants