SignalR Client Features doc -> SignalR Clients overview doc #18293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
requested review from
halter73,
BrennanConroy,
scottaddie and
bradygaster
|
TOC update preview:
|
scottaddie
requested changes
May 13, 2020
bradygaster
approved these changes
May 13, 2020
There was a problem hiding this comment.
approved provided Addie's suggestions go in. And @halter73's suggestion in the thread would make me very happy and I think mitigate lots of confusion with customers. If it would also simplify the engineering process, let's discuss how to make it happen.
Co-authored-by: Scott Addie <[email protected]>
BrennanConroy
approved these changes
May 14, 2020
scottaddie
approved these changes
May 14, 2020
|
@anurse Looks good. Merge when you're ready. Consider that contraction a parting gift for you. 😄 |
|
and while we're at it, I have to get one last lonely man usage in there. |
|
😭😭😭😭😭😭😭 |
halter73
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing dotnet/aspnetcore#21618 and other issues about compatibility and versioning I figured this doc could use a quick update. Here's a first stab at it. I'm going to check the TOCs shortly and look at the internal review site, since I changed some titles.