Binary Serialization is being removed

[TheAngryByrd]

I installed dotnet preview 9 and with DOTNET_ROLL_FORWARD_TO_PRERELEASE=1 I'm getting this error during build.

       Using "WebSharperTask" task from assembly "C:\Users\jimmy\.nuget\packages\websharper.fsharp\6.1.7.441-net8\build\/../tools/netstandard2.0/WebSharper.MSBuild.FSharp.dll".
       Task "WebSharperTask"
         C:\Users\jimmy\.nuget\packages\websharper.fsharp\6.1.7.441-net8\build\/../tools/net8.0/win-x64/wsfsc.exe "@C:\Users\jimmy\AppData\Local\Temp\tmpsyctnf.tmp"
         Unhandled exception. System.PlatformNotSupportedException: BinaryFormatter serialization and deserialization have been removed. See https://aka.ms/binaryformatter for more information.
            at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph)
            at WebSharper.FSharp.NamedPipeClient.sendCompileCommand(String[] args)
            at WebSharper.FSharp.Program.main(String[] argv)
 28:148>C:\Users\jimmy\.nuget\packages\websharper.fsharp\6.1.7.441-net8\build\WebSharper.FSharp.targets(50,5): error MSB6006: "wsfsc.exe" exited with code -532462766.

---

Binary Formatter has been doing a slow obsolete for a while:

• BinaryFormatter Obsoletion Strategy
• Announcement: BinaryFormatter is being removed in .NET 9 dotnet/runtime#98245

[granicz]

I am not up to date on the current serialization options, @TheAngryByrd - what's your take on the best way forward?

[TheAngryByrd]

Since ArgsType seems to be record with string array:

core/src/compiler/WebSharper.Compiler/WsFscServiceCommon.fs

Line 6 in 35c354b

type ArgsType = {args: string array}

Replacing BinaryFormatter calls it with something like System.Text.Json should be fairly straight forward.

[granicz]

OK, had a quick look, the offending piece is in the Booster communication code, and indeed should be quick to change it to use a more appropriate serializer. /cc @Jooseppi12

[granicz]

@Jooseppi12 Is this released, and if so, what version? If not, let's roll it out.

[Jooseppi12]

This is released for the WebSharper 8 packages on our GitHub feed, but was not backported to the websharper6 branch

[granicz]

OK, keeping this ticket open for the WS6 port as well.