This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fixed the spa project #2126
Merged
Fixed the spa project #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up the SPA project (removed dead code) - Fixed URLs in override file
davidfowl
commented
Jun 15, 2023
| - Identity__Url=http://${ESHOP_EXTERNAL_DNS_NAME_OR_IP}:5105 | ||
| - PurchaseUrl=http://${ESHOP_EXTERNAL_DNS_NAME_OR_IP}:5202 | ||
| - IdentityUrl=http://${ESHOP_EXTERNAL_DNS_NAME_OR_IP}:5105 | ||
| - PurchaseUrl=http://${ESHOP_EXTERNAL_DNS_NAME_OR_IP}:5121 |
There was a problem hiding this comment.
This is the real cors fix (going through the bff instead of envoy). I'll drop envoy from a future commit.
ReubenBond
reviewed
Jun 15, 2023
ReubenBond
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121