Swamy/remove unused using and refactor the code

src/Tests/Services/Application.FunctionalTests/Services/Catalog/CatalogScenariosBase.cs

@@ -27,7 +27,7 @@ public TestServer CreateServer()
                     .AddEnvironmentVariables();
                 }).UseStartup<Startup>();
 
-            var testServer =  new TestServer(hostBuilder);
+            var testServer = new TestServer(hostBuilder);
 
             testServer.Host
                 .MigrateDbContext<CatalogContext>((context, services) =>

src/Tests/Services/Application.FunctionalTests/Services/IntegrationEventsScenarios.cs

@@ -43,8 +43,8 @@ public async Task Post_update_product_price_and_catalog_and_basket_list_modified
                 var oldPrice = itemToModify.UnitPrice;
                 var newPrice = oldPrice + priceModification;
                 var pRes = await catalogClient.PutAsync(CatalogScenariosBase.Put.UpdateCatalogProduct, new StringContent(ChangePrice(itemToModify, newPrice, originalCatalogProducts), UTF8Encoding.UTF8, "application/json"));
-                                
-                var modifiedCatalogProducts = await GetCatalogAsync(catalogClient);               
+
+                var modifiedCatalogProducts = await GetCatalogAsync(catalogClient);
 
                 var itemUpdated = await GetUpdatedBasketItem(newPrice, itemToModify.ProductId, userId, basketClient);
 
@@ -71,7 +71,7 @@ private async Task<BasketItem> GetUpdatedBasketItem(decimal newPrice, int produc
             BasketItem itemUpdated = null;
 
             while (continueLoop && counter < 20)
-            {                
+            {
                 //get the basket and verify that the price of the modified product is updated
                 var basketGetResponse = await basketClient.GetAsync(BasketScenariosBase.Get.GetBasketByCustomer(userId));
                 var basketUpdated = JsonConvert.DeserializeObject<CustomerBasket>(await basketGetResponse.Content.ReadAsStringAsync());
@@ -92,7 +92,7 @@ private async Task<BasketItem> GetUpdatedBasketItem(decimal newPrice, int produc
             return itemUpdated;
         }
 
-        private async  Task<PaginatedItemsViewModel<CatalogItem>> GetCatalogAsync(HttpClient catalogClient)
+        private async Task<PaginatedItemsViewModel<CatalogItem>> GetCatalogAsync(HttpClient catalogClient)
         {
             var response = await catalogClient.GetAsync(CatalogScenariosBase.Get.Items);
             var items = await response.Content.ReadAsStringAsync();

src/Tests/Services/Application.FunctionalTests/Services/Marketing/UserLocationRoleScenariosBase.cs

@@ -15,7 +15,7 @@ public static string UserLocationRuleByCampaignAndUserLocationRuleId(int campaig
 
         public static class Post
         {
-            public static string AddNewuserLocationRule(int campaignId) 
+            public static string AddNewuserLocationRule(int campaignId)
                 => GetUserLocationRolesUrlBase(campaignId);
         }
 

src/Tests/Services/Application.FunctionalTests/Services/Ordering/OrderingScenarios.cs

@@ -15,7 +15,7 @@
 namespace FunctionalTests.Services.Ordering
 {
     public class OrderingScenarios : OrderingScenariosBase
-    {        
+    {
         [Fact]
         public async Task Cancel_basket_and_check_order_status_cancelled()
         {
@@ -69,7 +69,8 @@ private async Task<Order> TryGetNewOrderCreated(string city, HttpClient orderCli
                 var ordersGetResponse = await orderClient.GetStringAsync(OrderingScenariosBase.Get.Orders);
                 var orders = JsonConvert.DeserializeObject<List<Order>>(ordersGetResponse);
 
-                if (orders == null || orders.Count == 0) {
+                if (orders == null || orders.Count == 0)
+                {
                     counter++;
                     await Task.Delay(100);
                     continue;
@@ -84,9 +85,9 @@ private async Task<Order> TryGetNewOrderCreated(string city, HttpClient orderCli
                 if (IsOrderCreated(order, city))
                 {
                     break;
-                }                
-            }                
-            
+                }
+            }
+
             return order;
         }
 
@@ -117,7 +118,7 @@ string BuildCancelOrder(string orderId)
             var order = new OrderDTO()
             {
                 OrderNumber = orderId
-            };           
+            };
             return JsonConvert.SerializeObject(order);
         }
 
@@ -135,12 +136,11 @@ string BuildCheckout(string cityExpected)
                 CardExpiration = DateTime.Now.AddYears(1),
                 CardSecurityNumber = "123",
                 CardTypeId = 1,
-                Buyer = "Buyer",                
+                Buyer = "Buyer",
                 RequestId = Guid.NewGuid()
             };
 
             return JsonConvert.SerializeObject(checkoutBasket);
         }
     }
 }
-

src/Web/WebMVC/AppSettings.cs

@@ -1,9 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
-
-namespace Microsoft.eShopOnContainers.WebMVC
+namespace Microsoft.eShopOnContainers.WebMVC
 {
     public class AppSettings
     {

src/Web/WebMVC/Controllers/CampaignsController.cs

@@ -2,16 +2,16 @@ namespace Microsoft.eShopOnContainers.WebMVC.Controllers
 {
     using AspNetCore.Authorization;
     using AspNetCore.Mvc;
-    using global::WebMVC.Services.ModelDTOs;
     using global::WebMVC.Services;
+    using global::WebMVC.Services.ModelDTOs;
     using global::WebMVC.ViewModels;
+    using Microsoft.AspNetCore.Authentication.OpenIdConnect;
     using Microsoft.Extensions.Options;
     using Services;
     using System;
     using System.Threading.Tasks;
     using ViewModels;
     using ViewModels.Pagination;
-    using Microsoft.AspNetCore.Authentication.OpenIdConnect;
 
     [Authorize(AuthenticationSchemes = OpenIdConnectDefaults.AuthenticationScheme)]
     public class CampaignsController : Controller
@@ -31,12 +31,12 @@ public async Task<IActionResult> Index(int page = 0, int pageSize = 10)
         {
             var campaignList = await _campaignService.GetCampaigns(pageSize, page);
 
-            if(campaignList is null)
+            if (campaignList is null)
             {
                 return View();
             }
 
-            var totalPages = (int) Math.Ceiling((decimal) campaignList.Count / pageSize);
+            var totalPages = (int)Math.Ceiling((decimal)campaignList.Count / pageSize);
 
             var vm = new CampaignViewModel
             {

src/Web/WebMVC/Controllers/CatalogController.cs

@@ -1,21 +1,20 @@
-using System;
-using System.Threading.Tasks;
-using Microsoft.AspNetCore.Mvc;
-using Microsoft.eShopOnContainers.WebMVC.ViewModels.Pagination;
+using Microsoft.AspNetCore.Mvc;
 using Microsoft.eShopOnContainers.WebMVC.Services;
 using Microsoft.eShopOnContainers.WebMVC.ViewModels.CatalogViewModels;
-using Microsoft.AspNetCore.Http;
+using Microsoft.eShopOnContainers.WebMVC.ViewModels.Pagination;
+using System;
+using System.Threading.Tasks;
 
 namespace Microsoft.eShopOnContainers.WebMVC.Controllers
 {
     public class CatalogController : Controller
     {
         private ICatalogService _catalogSvc;
 
-        public CatalogController(ICatalogService catalogSvc) => 
+        public CatalogController(ICatalogService catalogSvc) =>
             _catalogSvc = catalogSvc;
 
-        public async Task<IActionResult> Index(int? BrandFilterApplied, int? TypesFilterApplied, int? page, [FromQuery]string errorMsg)
+        public async Task<IActionResult> Index(int? BrandFilterApplied, int? TypesFilterApplied, int? page, [FromQuery] string errorMsg)
         {
             var itemsPage = 10;
             var catalog = await _catalogSvc.GetCatalogItems(page ?? 0, itemsPage, BrandFilterApplied, TypesFilterApplied);
@@ -30,7 +29,7 @@ public async Task<IActionResult> Index(int? BrandFilterApplied, int? TypesFilter
                 {
                     ActualPage = page ?? 0,
                     ItemsPerPage = catalog.Data.Count,
-                    TotalItems = catalog.Count, 
+                    TotalItems = catalog.Count,
                     TotalPages = (int)Math.Ceiling(((decimal)catalog.Count / itemsPage))
                 }
             };

src/Web/WebMVC/Controllers/OrderManagementController.cs

@@ -1,13 +1,10 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
+using Microsoft.AspNetCore.Authentication.OpenIdConnect;
+using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
-using WebMVC.Services.ModelDTOs;
 using Microsoft.eShopOnContainers.WebMVC.Services;
 using Microsoft.eShopOnContainers.WebMVC.ViewModels;
-using Microsoft.AspNetCore.Authorization;
-using Microsoft.AspNetCore.Authentication.OpenIdConnect;
+using System.Threading.Tasks;
+using WebMVC.Services.ModelDTOs;
 
 namespace WebMVC.Controllers
 {
@@ -37,7 +34,7 @@ public async Task<IActionResult> OrderProcess(string orderId, string actionCode)
             {
                 await _orderSvc.ShipOrder(orderId);
             }
-            
+
             return RedirectToAction("Index");
         }
     }

src/Web/WebMVC/Controllers/TestController.cs

@@ -48,7 +48,7 @@ public async Task<IActionResult> Ocelot()
 
             if (response.IsSuccessStatusCode)
             {
-                var str =  await response.Content.ReadAsStringAsync();
+                var str = await response.Content.ReadAsStringAsync();
 
                 return Ok(str);
             }

src/Web/WebMVC/Extensions/HttpClientExtensions.cs

@@ -1,11 +1,8 @@
 using System;
-using System.Collections.Generic;
 using System.IdentityModel.Tokens.Jwt;
-using System.Linq;
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Text;
-using System.Threading.Tasks;
 
 namespace Microsoft.eShopOnContainers.WebMVC.Extensions
 {

src/Web/WebMVC/Extensions/SessionExtensions.cs

@@ -1,9 +1,5 @@
 using Microsoft.AspNetCore.Http;
 using Newtonsoft.Json;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
 
 
 public static class SessionExtensions

src/Web/WebMVC/Infrastructure/HttpClientRequestIdDelegatingHandler.cs

@@ -22,7 +22,7 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
                     request.Headers.Add("x-requestid", Guid.NewGuid().ToString());
                 }
             }
-            
+
             return await base.SendAsync(request, cancellationToken);
         }
     }

src/Web/WebMVC/Infrastructure/Middlewares/ByPassAuthMiddleware.cs

@@ -1,7 +1,6 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Primitives;
 using System;
-using System.Collections.Generic;
 using System.Linq;
 using System.Security.Claims;
 using System.Threading.Tasks;
@@ -63,7 +62,7 @@ public async Task Invoke(HttpContext context)
                     new Claim("name", "Test user"),
                     new Claim("nonce", Guid.NewGuid().ToString()),
                     new Claim("http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name", "Test user"),
-                    new Claim("http://schemas.microsoft.com/identity/claims/identityprovider", "ByPassAuthMiddleware"),                    
+                    new Claim("http://schemas.microsoft.com/identity/claims/identityprovider", "ByPassAuthMiddleware"),
                     new Claim("http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname","User"),
                     new Claim("sub", currentUserId),
                     new Claim("card_expiration", "12/21"),

src/Web/WebMVC/Infrastructure/WebContextSeed.cs

@@ -35,7 +35,7 @@ public static void Seed(IApplicationBuilder applicationBuilder, IWebHostEnvironm
         static void GetPreconfiguredCSS(string contentRootPath, string webroot, ILogger log)
         {
             try
-            { 
+            {
                 string overrideCssFile = Path.Combine(contentRootPath, "Setup", "override.css");
                 if (!File.Exists(overrideCssFile))
                 {
@@ -44,7 +44,7 @@ static void GetPreconfiguredCSS(string contentRootPath, string webroot, ILogger
                 }
 
                 string destinationFilename = Path.Combine(webroot, "css", "override.css");
-                File.Copy(overrideCssFile, destinationFilename, true );
+                File.Copy(overrideCssFile, destinationFilename, true);
             }
             catch (Exception ex)
             {
@@ -86,7 +86,7 @@ static void GetPreconfiguredImages(string contentRootPath, string webroot, ILogg
                     }
                 }
             }
-            catch ( Exception ex )
+            catch (Exception ex)
             {
                 log.Error(ex, "EXCEPTION ERROR: {Message}", ex.Message);
             }

src/Web/WebMVC/Program.cs

@@ -42,13 +42,13 @@ public static int Main(string[] args)
 
         private static IWebHost BuildWebHost(IConfiguration configuration, string[] args) =>
             WebHost.CreateDefaultBuilder(args)
-                .CaptureStartupErrors(false)                
+                .CaptureStartupErrors(false)
                 .ConfigureAppConfiguration(x => x.AddConfiguration(configuration))
                 .UseStartup<Startup>()
                 .UseSerilog()
                 .Build();
 
-         private static Serilog.ILogger CreateSerilogLogger(IConfiguration configuration)
+        private static Serilog.ILogger CreateSerilogLogger(IConfiguration configuration)
         {
             var seqServerUrl = configuration["Serilog:SeqServerUrl"];
             var logstashUrl = configuration["Serilog:LogstashgUrl"];
@@ -57,10 +57,12 @@ private static Serilog.ILogger CreateSerilogLogger(IConfiguration configuration)
                 .Enrich.WithProperty("ApplicationContext", AppName)
                 .Enrich.FromLogContext()
                 .WriteTo.Console();
-            if (!string.IsNullOrWhiteSpace(seqServerUrl)) {
+            if (!string.IsNullOrWhiteSpace(seqServerUrl))
+            {
                 cfg.WriteTo.Seq(seqServerUrl);
             }
-            if (!string.IsNullOrWhiteSpace(logstashUrl)) {
+            if (!string.IsNullOrWhiteSpace(logstashUrl))
+            {
                 cfg.WriteTo.Http(logstashUrl);
             }
             return cfg.CreateLogger();

src/Web/WebMVC/Services/BasketService.cs

@@ -23,7 +23,7 @@ public BasketService(HttpClient httpClient, IOptions<AppSettings> settings, ILog
         {
             _apiClient = httpClient;
             _settings = settings;
-            _logger =logger;
+            _logger = logger;
 
             _basketByPassUrl = $"{_settings.Value.PurchaseUrl}/b/api/v1/basket";
             _purchaseUrl = $"{_settings.Value.PurchaseUrl}/api/v1";
@@ -33,7 +33,7 @@ public async Task<Basket> GetBasket(ApplicationUser user)
         {
             var uri = API.Basket.GetBasket(_basketByPassUrl, user.Id);
             _logger.LogDebug("[GetBasket] -> Calling {Uri} to get the basket", uri);
-            var response = await _apiClient.GetAsync(uri);  
+            var response = await _apiClient.GetAsync(uri);
             _logger.LogDebug("[GetBasket] -> response code {StatusCode}", response.StatusCode);
             var responseString = await response.Content.ReadAsStringAsync();
             return string.IsNullOrEmpty(responseString) ?
@@ -97,7 +97,7 @@ public async Task<Order> GetOrderDraft(string basketId)
 
             var responseString = await _apiClient.GetStringAsync(uri);
 
-            var response =  JsonConvert.DeserializeObject<Order>(responseString);
+            var response = JsonConvert.DeserializeObject<Order>(responseString);
 
             return response;
         }

src/Web/WebMVC/Services/IBasketService.cs

@@ -1,7 +1,5 @@
 using Microsoft.eShopOnContainers.WebMVC.ViewModels;
-using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading.Tasks;
 using WebMVC.Services.ModelDTOs;
 

src/Web/WebMVC/Services/ICampaignService.cs

@@ -1,6 +1,5 @@
 namespace Microsoft.eShopOnContainers.WebMVC.Services
 {
-    using System.Collections.Generic;
     using System.Threading.Tasks;
     using ViewModels;
 

src/Web/WebMVC/Services/ICatalogService.cs

@@ -1,8 +1,6 @@
 using Microsoft.AspNetCore.Mvc.Rendering;
 using Microsoft.eShopOnContainers.WebMVC.ViewModels;
-using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading.Tasks;
 
 namespace Microsoft.eShopOnContainers.WebMVC.Services

src/Web/WebMVC/Services/IIdentityParser.cs

@@ -1,8 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Security.Principal;
-using System.Threading.Tasks;
+using System.Security.Principal;
 
 namespace Microsoft.eShopOnContainers.WebMVC.Services
 {

src/Web/WebMVC/Services/IOrderingService.cs

@@ -1,7 +1,5 @@
 using Microsoft.eShopOnContainers.WebMVC.ViewModels;
-using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading.Tasks;
 using WebMVC.Services.ModelDTOs;