Service Bus persisted connection for ISubscriptionClient

[Marusyk]

There is the code for TopicClient :

var topicClient = _serviceBusPersisterConnection.CreateModel();

eShopOnContainers/src/BuildingBlocks/EventBus/EventBusServiceBus/DefaultServiceBusPersisterConnection.cs

Lines 27 to 35 in 1b72007

	public ITopicClient CreateModel()
	{
	if(_topicClient.IsClosedOrClosing)
	{
	_topicClient = new TopicClient(_serviceBusConnectionStringBuilder, RetryPolicy.Default);
	}
	return _topicClient;
	}

Shouldn't we do the same for ISubscriptionClient?

if(_subscriptionClient.IsClosedOrClosing)
{
      _subscriptionClient = new SubscriptionClient(serviceBusPersisterConnection.ServiceBusConnectionStringBuilder, subscriptionClientName);
}

return _subscriptionClient;

Q2. is it a typo in the class name:

eShopOnContainers/src/BuildingBlocks/EventBus/EventBusServiceBus/DefaultServiceBusPersisterConnection.cs

Line 7 in 1b72007

public class DefaultServiceBusPersisterConnection :IServiceBusPersisterConnection

Persister or Persisted?

[sughosneo]

Hi @Marusyk, thank you for your feedback.

As SubscriptionClient also implements interface IClientEntity which actually holds the property IsClosedOrClosing. It can be used to check if the client connection is healthy or not. That could be applicable to any client.

Would you like to submit a PR ? Also, you may want to test out the changes with Azure Service Bus.

And in terms of Q2) - to my opinion, we can leave the custom class name with Persister as it has been used as Noun and consistent in all the places.

[Marusyk]

Thank you for answer. I'll prepare a PR for this.

[Marusyk]

Hey @sughosneo

And in terms of Q2) - to my opinion, we can leave the custom class name with Persister as it has been used as Noun and consistent in all the places.

For Rabbit implementation, it named IRabbitMQPersistentConnection.
It would be great to have the same name patter for ServiceBus and RabbitMq

[sughosneo]

I am closing this issue as of now as this has already been addressed. Please feel free to reopen it, if needed.

Thank you.