Replace docker.for.win.localhost with host.docker.internal in .env

[InstanceFactory]

According to docker/for-win#1764, docker.for.win.localhost is deprecated. The official new name is host.docker.internal.

When I tried to run eShopOnContainers on my Windows 10 machine, I was not able to login (as described e.g. by #1236 and #1242).

The current version of .env still contains docker.for.win.localhost for environment values to run the app locally in Windows. Changing docker.for.win.localhost to host.docker.internal in the .env file solved the issue for me.

I'm offering to make this change in the source code to help other (microservice) newbies like me not to run into this problem.

In case you agree, please assign this issue to me.

Best Regards,

Stefan

[sughosneo]

Hi Stefan, Thank you for pointing out.

Yes, docker.for.win.localhost is deprecated. In our recent wiki update, we have included host.docker.internal under Known Behaviours section.

I agree with you updating respective scripts as well. If you could make the necessary changes and submit a PR. We can review and merge the changes in.

[InstanceFactory]

Hi Sumit,

Thanks, I will do so.

Regards,

Stefan

[sughosneo]

PR #1400 has been merged. So closing this issue.

[InstanceFactory]

Hi @sughosneo , thanks for merging and closing.