Strict Liquid Syntax (Part 2) + Render Performance#441
Merged
microalps merged 10 commits intodotliquid:masterfrom Jul 28, 2021
Merged
Strict Liquid Syntax (Part 2) + Render Performance#441microalps merged 10 commits intodotliquid:masterfrom
microalps merged 10 commits intodotliquid:masterfrom
Conversation
Contributor
Author
|
Performance (based on Fluid's benchmark) vs latest NuGet |
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 85.07% 86.73% +1.66%
==========================================
Files 61 62 +1
Lines 2452 2511 +59
Branches 670 599 -71
==========================================
+ Hits 2086 2178 +92
+ Misses 223 213 -10
+ Partials 143 120 -23
Continue to review full report at Codecov.
|
daviburg
requested changes
Jul 8, 2021
daviburg
reviewed
Jul 9, 2021
microalps
changed the title
Contributor
Author
|
Here is an updated benchmark, accounting for the differences in behavior between DotLiquid 2.1 and 2.2 Summary: 2.2 gives a 10% edge over 2.1 on render and on parse operations. Overall, rendering can be 65% - 80% faster when utilizing all the performance tweaks. |
daviburg
requested changes
Jul 13, 2021
daviburg
approved these changes
Jul 27, 2021
Member
|
I'm trying to use inline suggestion for minor/cosmetic changes so you can just click on the accept button. Approved to merge with only these minor comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves upon render time with a slew of under the hood changes. Notable changes:
For all versions:
With an opt-in flag for DotLiquid 2.2 Syntax
It remains unknown how much this impacts the benchmarks on RicoSuter/NJsonSchema#1346 ... would love to hear from that team