Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #1

Merged
merged 5 commits into from
May 7, 2019
Merged

Code cleanup #1

merged 5 commits into from
May 7, 2019

Conversation

ZoeyR
Copy link
Contributor

@ZoeyR ZoeyR commented May 7, 2019

This PR addresses multiple issues to help clean up the code

  • switch to cargo workspaces
  • make sure tests pass on all platforms
  • use the correct repo links
  • switch to azure pipelines

The azure pipelines switch isn't complete yet because this repo needs to be set up to connect to azure. I'm not an admin/owner so I can't configure that myself.

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6289ff1). Click here to learn what that means.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   85.95%           
=========================================
  Files             ?       17           
  Lines             ?      349           
  Branches          ?        0           
=========================================
  Hits              ?      300           
  Misses            ?       49           
  Partials          ?        0
Impacted Files Coverage Δ
dotenv/src/iter.rs 95.83% <ø> (ø)
dotenv/src/find.rs 92.59% <ø> (ø)
dotenv/src/errors.rs 0% <ø> (ø)
dotenv/src/lib.rs 100% <ø> (ø)
dotenv/src/parse.rs 98.4% <ø> (ø)
dotenv_codegen_impl/src/lib.rs 0% <0%> (ø)
dotenv/tests/test-default-location.rs 87.5% <100%> (ø)
dotenv/tests/test-from-filename-iter.rs 90% <100%> (ø)
dotenv/tests/test-from-path-iter.rs 91.66% <100%> (ø)
dotenv/tests/test-from-path.rs 90% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6289ff1...5d9b342. Read the comment docs.

dotenv/Cargo.toml Outdated Show resolved Hide resolved
dotenv/Cargo.toml Outdated Show resolved Hide resolved
dotenv/Cargo.toml Outdated Show resolved Hide resolved
@projektir
Copy link

Looks good overall. Please squash the commits. :)

@ZoeyR ZoeyR merged commit d62b206 into dotenv-rs:master May 7, 2019
@ZoeyR ZoeyR deleted the code-cleanup branch May 14, 2019 04:56
swchoi1997 added a commit to swchoi1997/dotenv that referenced this pull request Oct 10, 2024
This function is similar to the existing dotenv function, but instead of setting
environment variables, it returns the contents of the .env file as a HashMap.
This allows users to handle the contents of the .env file more flexibly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants