Add memory limit waiver for pid #1315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronz88
requested changes
Dec 22, 2024
| @@ -40,6 +40,14 @@ def signal(self, pid: int, sig: int): | |||
| self._channel.sendSignal_toPid_(MessageAux().append_obj(sig).append_obj(pid), expects_reply=True) | |||
| return self._channel.receive_plist() | |||
|
|
|||
| def memlimitoff(self, pid: int) -> list: | |||
There was a problem hiding this comment.
please add a docstring for the returned list and supply the list with a specific type (e.g. list[dict[str, str]]]).
I know still most of current API don't use these typing, but I'm trying that at least all new code or modified one will have better typings
| """ | ||
| Test disabling memory limit. | ||
| """ | ||
| aggregated = get_process_data(dvt, 'SpringBoard') |
There was a problem hiding this comment.
Probably meant springboard for the variable? or did u actually plan to check with SpringBoard?
| res = ProcessControl(dvt).memlimitoff(aggregated['pid']) | ||
| # give the os some time to respond | ||
| time.sleep(3) | ||
| assert res |
There was a problem hiding this comment.
depending on what should be returned, maybe add a better verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS provides strict limits regarding memory usage (especially for extensions).
There is a method
- (NSNumber *)requestDisableMemoryLimitsForPid:(int)arg1;of header fileDTProcessControlServiceAuthorizedMethods.hwhich sounded promising to utilizeBy sending a message call to invoke that method, the iOS responds with either 0 (false) or 1 (true) if memory limit disabling request was declined or satisfied respectively
Full command to test:
Expected command output:
OR