Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'sh:' directives a bit more usable #17

Merged
merged 10 commits into from
Apr 17, 2020
Merged

Conversation

doronbehar
Copy link
Owner

@doronbehar doronbehar commented Apr 16, 2020

To fix #16 , and to make sh: work for (I hope) most edge cases, some api changes are needed - above all: use a different placeholder for the file name in command definitions. In this PR %pistol-filename% is used instead of %s.

TODO:

  • Consider implementing a somewhat backwards compatible interface
  • Release a new version if this will be a breaking change.
  • If releasing, use the GitHub release notes feature.
  • If releasing, put a banner in the README to indicate that for users with broken configs.
  • Update README in general.

Other then that, the version presented in this PR (essentially what's in the sh-fixes-and-new-api branch) should be usable, after switching the configs from using %s to %pistol-filename%.

@doronbehar doronbehar mentioned this pull request Apr 16, 2020
@doronbehar doronbehar merged commit 862350d into master Apr 17, 2020
@doronbehar doronbehar deleted the sh-fixes-and-new-api branch July 12, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help with sh:
1 participant