-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Zipper.find_all/3 #163
Conversation
|> Z.next() | ||
|> Z.next() | ||
|> Z.next() | ||
|> Z.next() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is a better way to get to the last node let me know. I tried Zipper.rightmost
but I think that only goes to the right most of the current node
FYI unrelated tests failing with Elixir 1.17
|
94acb03
to
d70c6d9
Compare
force pushed format fix for CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
About the 1.17 test issues, it seems some bugs in the elixir parser were fixed in core elixir. We can either backport those fixes in a new PR, or adopt lib_elixir(I have a POC here but there's some polishing needed to make it work appropriately)
No description provided.