Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extract comments #151

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented Jun 20, 2024

This is a potential fix for #150

I honestly have no idea if this is correct, but it did technically result in the fix for the specific example I was looking at.

But it didn't really feel right 😆 . Happy to be corrected.

Copy link
Owner

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix makes total sense, it's incorrect to assume nodes with a single child will always have an empty accumulator!

@doorgan doorgan merged commit eb06d01 into doorgan:main Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants