improvement: track supertree, and add Zipper.all_the_way_up/1
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doorgan
reviewed
Jun 14, 2024
lib/sourceror/zipper.ex
Outdated
Comment on lines
93
to
101
| @doc """ | ||
| Walks the `zipper` all the way up, breaking out of any subtrees and returns the top-most `zipper`. | ||
| """ | ||
| @spec all_the_way_up(t) :: t | ||
| def all_the_way_up(%Z{supertree: supertree} = zipper) when not is_nil(supertree) do | ||
| all_the_way_up(into(top(zipper), supertree)) | ||
| end | ||
|
|
||
| def all_the_way_up(zipper), do: top(zipper) |
There was a problem hiding this comment.
Maybe we can call this topmost? It feels a bit more consistent with the names rightmost and leftmost
There was a problem hiding this comment.
I like topmost 👍
|
Should we also include |
|
Happy to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really think that
all_the_way_up/1is a great name, and I had to resist the urge to call itZipper.tippy_top/1😂Open to suggestions.