Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor zipper #139

Merged
merged 1 commit into from
May 24, 2024
Merged

Refactor zipper #139

merged 1 commit into from
May 24, 2024

Conversation

NickNeck
Copy link
Contributor

Hi, I have made some refactoring to the zipper.

It could be too much for a PR, and no changes are necessary. However, it shortens the code and makes it a bit more readable—not that it is not readable in the current version.

Changes:

  • the function subtree was simplified and inlined to use it in the traverse* functions.
  • a private function into was created to use it in the traverse functions.
  • the private function prev_after_remove was removed because it was a duplicate of do_prev.
  • added some function headers to get the right argument names in the generated docs.
  • added some highlighting in the docs.

Copy link
Owner

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, thanks for all these improvements! 💜

@doorgan doorgan merged commit bfd31d4 into doorgan:main May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants