Refactor comment handling #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2024
doorgan
approved these changes
May 9, 2024
|
This is live in v1.1.0! |
Great. Thank you.
No need to be sorry. It is your spare free time that you invest in this great project. Another thank you for all your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53 even if the title of the ticket mentioned trailing comments.
The PR refactors two things. The first refactoring changes the handling of trailing blocks. There are now some extra functions to handle the trailing blocks in separate functions. The AST inside the trailing block is always treated in the same way.
The other change concerns the line correction for leading and trailing comments. Then new version counts the newlines in the comments and not just the count of the comments.
The changes also make it necessary to adjust expected results in the tests. But I think that changes are making sense.