Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_range/1 for binaries #120

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Fix get_range/1 for binaries #120

merged 2 commits into from
Jan 18, 2024

Conversation

rrrene
Copy link
Contributor

@rrrene rrrene commented Jan 18, 2024 •
edited
Loading

Hi congrats on going 1.0.0, that's always the big one.

I played around and found something:

It seems escaped double quotes are not counted in Sourceror.get_range/1:

~S"""
# the following line is 16 chars long, so `end_column` should be 17
"key: \"value\""
"""
|> Sourceror.parse_string!()
|> Sourceror.get_range()
|> dbg

Let me know what you think of this 👍

@rrrene
Add test showing failure
a7fa8b0
@rrrene
Fix bug regarding delimiters in strings
76ba0e0 
It seems escaped double quotes are not counted in `Sourceror.get_range/1`:

```elixir
~S"""
"key: \"value\""
"""
|> Sourceror.parse_string!()
|> Sourceror.get_range()
|> dbg
```
doorgan
doorgan approved these changes Jan 18, 2024
View reviewed changes
Copy link
Owner

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for the fix!

@doorgan doorgan merged commit 8ebc68b into doorgan:main Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doorgan doorgan doorgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrrene @doorgan