Change get_range/1
to allow returning nil
and add syntax corpus
#107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
Related to #105
While I was writing the proposal in #105, I suggested
has_range?
thinking that it might be possible to always be able to calculate a range for a 3-tuple. When adding the syntax corpus, however, I found that that doesn't seem to be the case for some injected nodes in interpolations or for empty blocks ({:__block__, [], []}
).So I went ahead and attempted the
get_range
refactor and it's not bad at all.Note that this is a breaking change currently. If we don't want to break the contract of
Sourceror.get_range/1
, we could easily do something like this: