fix(dirvish): include dired-x and newer defaults #6568

Dadams2 · 2022-07-18T13:09:52Z

Bumps the version to latest as doom is very far behind.
fixes the void-variable dired-omit-files experienced by users who have unpinned dirvish
adds a sensible quit binding for fullscreen
adds a sensible dirvish-mode-line-format consistent with the package authors recommendations (see https://github.com/alexluigit/dirvish/blob/main/CUSTOMIZING.org)
fixes popup window sizing issue experienced by users who have +all enabled for popup (see Preview on bottom with Doom alexluigit/dirvish#18)

This also implements the feedback of the package author in #6397 for the original pull request for this module that includes:

replaces fd-dired with dirvish-fd
removes the +dired/quit-all binding
adds a binding for dired-dispatch similar to that of magit and treemacs
replaces diff-hl-dired-mode with dirvish's inbuilt vc-state

the +dirvish flag is currently undocumented in the modules. But I am assuming this will need to be a separate PR.

Fixes #6562
References #6397
Replaces #6566 #6567

Before:

After:

[x ] I searched the issue tracker and this hasn't been PRed before.
[ x] My changes are not on the do-not-PR list for this project.
[ x] My commits conform to the git conventions.
[ x] My changes are visual; I've included before and after screenshots.
[x ] Any relevant issues or PRs have been linked to.

alexluigit · 2022-07-19T15:05:41Z

Hi, thanks for your contribution.

Perhaps we should disable centaur tabs in the dirvish buffer, makes it look cleaner.

:hook (dirvish-mode . centaur-tabs-local-mode)

Of course there should be some type of featurep! check around it but I don't know the module name.

teehemkay · 2022-07-20T09:04:51Z

Of course there should be some type of featurep! check around it but I don't know the module name.

(featurep! ui: tabs +centaur-tabs)

alexluigit · 2022-07-21T14:28:59Z

I've added the dirvish-quit command at alexluigit/dirvish@5662f7f. By default it is bound to q, but for doom I guess we still need to bind it in normal map.

Dadams2 · 2022-07-24T06:04:49Z

So I really tried to get rid of all of the centaur tabs but have been unsuccessful thus far as is evidenced by the current state:

Some things I have tried:

(add-hook! 'dirvish-mode-hook (when centaur-tabs-mode (centaur-tabs-local-mode)))

(add-hook! 'dirvish-mode-hook (centaur-tabs-local-mode -1))

(add-hook! '(dirvish-mode-hook dirvish-find-entry-hook) (when centaur-tabs-mode (centaur-tabs-local-mode)))

(thanks @tecosaur for helping me with this pain)

alexluigit · 2022-07-24T06:41:03Z

  (after! centaur-tabs
          (add-hook! 'dirvish-mode-hook 'centaur-tabs-local-mode))

BTW please fix the commit hash, 86b7002d3b035b1a314775db5ff1946e29bd33ef. Sorry for the overwrite.

Dadams2 · 2022-07-24T07:22:37Z

My bad, I must have grabbed the commit hash in between your commits. So I tried that snippet both in my personal config and in the package config. Same result as the existing hook. The centaur-tabs will not go away in the preview buffer.

alexluigit · 2022-07-24T08:43:25Z

I'm pretty sure this would work (at least on Emacs 29)

(use-package! dirvish
  :defer t
  :when (featurep! +dirvish)
  :init (dirvish-override-dired-mode)
  :config
  (after! centaur-tabs
          (add-hook! 'dirvish-mode-hook 'centaur-tabs-local-mode))
;; ...
)

@hlissner , it is okay to use :init (dirvish-override-dired-mode) here? This overrider does not require anything, perhaps we don't have to use :init (after! dired ....)

I believe (require 'dired-x) and :hook (dired-mode . dired-omit-mode) are uncessary since they are declared in (use-package! dired-x ...) block. Can you attest that?

Also, maybe consider giving dirvish a binding.

diff --git a/modules/config/default/+emacs-bindings.el b/modules/config/default/+emacs-bindings.el
index 6bac7a5bc..aec703b86 100644
--- a/modules/config/default/+emacs-bindings.el
+++ b/modules/config/default/+emacs-bindings.el
@@ -236,6 +236,8 @@
        :desc "REPL"               "r"  #'+eval/open-repl-other-window
        :desc "REPL (same window)" "R"  #'+eval/open-repl-same-window
        :desc "Dired"              "-"  #'dired-jump
+       (:when (featurep! :emacs dired +dirvish)
+        :desc "Dired with preview"            "v" #'dirvish)
        (:when (featurep! :ui neotree)
         :desc "Project sidebar"               "p" #'+neotree/open
         :desc "Find file in project sidebar"  "P" #'+neotree/find-this-file)
diff --git a/modules/config/default/+evil-bindings.el b/modules/config/default/+evil-bindings.el
index 72b124095..408284d5b 100644
--- a/modules/config/default/+evil-bindings.el
+++ b/modules/config/default/+evil-bindings.el
@@ -604,6 +604,8 @@
        :desc "REPL"               "r"  #'+eval/open-repl-other-window
        :desc "REPL (same window)" "R"  #'+eval/open-repl-same-window
        :desc "Dired"              "-"  #'dired-jump
+       (:when (featurep! :emacs dired +dirvish)
+        :desc "Dired with preview"           "v" #'dirvish)
        (:when (featurep! :ui neotree)
         :desc "Project sidebar"              "p" #'+neotree/open
         :desc "Find file in project sidebar" "P" #'+neotree/find-this-file)

smallstepman · 2022-07-26T10:52:43Z

looks like the +dirvish flag is undocumented, but I'm not sure if this PR is the right place for such changes

Dadams2 · 2022-07-27T05:27:03Z

Just wanted to say thank you @alexluigit, your config also works for me on emacs 28.1.5 and 28.1.
I still think it is good to have the (when (featurep! ..... in the case of centaur tabs though. Although perhaps there is a better way to do it. I am no expert.

In regards to bindings I'm not sure. The decision obviously rests with @hlissner. I always saw dirvish as a replacement for dired as it had everything I wanted. Currently SPC o - brings up dirvish without full-screen anyways. My preference would be to just bind something like SPC o _ or SPC o v to open dirvsih in fullscreen mode and leave as is. I am not fussed either way

Dadams2 · 2022-07-27T05:28:02Z

@smallstepman see my opening comment:

the +dirvish flag is currently undocumented in the modules. But I am assuming this will need to be a separate PR.

If documentation changes are to be made they will be to a PR against rewrite-docs after this PR has landed

Dadams2 · 2022-08-11T08:04:33Z

@alexluigit we should probably decide what bindings we want to propose. After playing around I am happy with your bindings and will push up shortly. Did you want to consider anything else?

alexluigit · 2022-08-13T12:24:13Z

If you mean the global keybindings, I think SPC o [key] for dirvish is enough for most users.
dirvish-dwim can be a little bit opinionated, I use it more often though. Binding dirvish-side globally might need a more extensive discussion, since the functionality is overlapped with treemacs/neotree, so maybe not in this PR.

For keybindings inside of dirvish I'll suggest

dirvish-subtree-toggle -> TAB.
dirvish-narrow is pretty handy in some cases.

BTW there are some obsolete command names in current commit:

dirvish-goto-bookmark -> dirvish-quick-access
dirvish-show-history -> dirvish-history-jump (dirvish-history-go-forward/backward seems more useful)
dirvish-toggle-fullscreen -> dirvish-layout-toggle

Dadams2 · 2022-09-14T01:15:13Z

Got caught up. Will leave in the hands of @alexluigit and #6760

BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info` `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@fb40a7f9e3c4 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/46bf051ef7c14bee4b0af48560b43e071fe62f6d/dirvish-extras.el#L172-L197 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info`, `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@a877ba816f90 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/a877ba816f907daea2d86bd10754bec6484e753a/dirvish-extras.el#L172-L190 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info`, `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@11a3bec247b9 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/a877ba816f907daea2d86bd10754bec6484e753a/dirvish-extras.el#L172-L190 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

commit 720ddad Author: Alex <[email protected]> Date: Sat Oct 1 14:12:50 2022 +0800 feat!(dired): use dirvish by default BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info`, `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@11a3bec247b9 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/a877ba816f907daea2d86bd10754bec6484e753a/dirvish-extras.el#L172-L190 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info`, `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@11a3bec247b9 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/a877ba816f907daea2d86bd10754bec6484e753a/dirvish-extras.el#L172-L190 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

commit 720ddad Author: Alex <[email protected]> Date: Sat Oct 1 14:12:50 2022 +0800 feat!(dired): use dirvish by default BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info`, `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@11a3bec247b9 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/a877ba816f907daea2d86bd10754bec6484e753a/dirvish-extras.el#L172-L190 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

BREAKING CHANGE: Deprecate `+ranger` flag, use package dirvish by default and rewrite the module based on it. Doing so we can remove these packages and their associated hacks: `all-the-icons-dired`, `dired-rsync`, `fd-dired`, `dired-git-info`, `ranger`. See file log below for details. purcell/diredfl@f9140b2c4215 -> purcell/diredfl@62b559e1d6b6 alexluigit/dirvish@73dcaa404da9 -> alexluigit/dirvish@11a3bec247b9 * modules/ui/vc-gutter/config.el(dired-mode-hook, diff-hl-dired-mode): when dired module is enabled, use `vc-state` from dirvish to render the vc gutter instead of diff-hl-dired-mode, doing so we get better performance and integration with the dired module. * modules/emacs/dired/autoload.el: delete this file since the commands in it are no longer used. * modules/emacs/dired/doctor.el: add deprecate warning for `+ranger` flag * modules/emacs/dired/README.org: rewrite based on the new features * modules/emacs/dired/config.el: - (dirvish-mode-line-format, dired-hide-details-hide-symlink-targets): set `dired-hide-details-hide-symlink-targets` to t, show symlink target on mode-line instead - (dired-listing-switches, +dired-disable-gnu-ls-flags-maybe-h): dirvish has inbuilt gnuls check, so the setup for `dired-listing-switches` can be simplified as such and the `+dired-disable-gnu-ls-flags-maybe-h` can be safely removed. - (+dired/quit-all): dirvish has a fine-tuned machinery for closing dired buffers, so replace this command with `dirvish-quit`. One can set `dirvish-reuse-session` to nil to get similar behavior to `+dired/quit-all`. - (dired-rsync): replace `dired-rsync` with `dirvish-rsync` - (+ranger): deprecate this flag. - (dirvish-attributes, all-the-icons-dired): remove package `all-the-icons-dired`, use `all-the-icons` attribute in dirvish to implement the `+icons` flag. - (fd-dired): use the better alternative dirvish-fd to replace this command/package. - (dirvish-attributes, dired-git-info-mode): use `git-msg` attribute from dirvish to replace dired-git-info-mode. - (dirvish-attributes): add `collapse` attribute for `+dirvish` flag - (dirvish-attributes): add `subtree-state` attribute for `+icons` flag - (dirvish-mode-map): introduce a few new keybindings such as `dirvish-subtree-toggle` - (dirvish-attributes, dirvish-use-header-line, dirvish-mode-line-format, dirvish-hide-cursor, dirvish-hide-details): support classic dired UI when +dirvish is not enabled. Fix: doomemacs#6562 Replace: doomemacs#6568 Ref: https://github.com/alexluigit/dirvish/blob/a877ba816f907daea2d86bd10754bec6484e753a/dirvish-extras.el#L172-L190 Ref: alexluigit/dirvish#34 Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#find-dired--fd-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#all-the-icons-dired Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-git-info--diff-hl--dired-k Ref: https://github.com/alexluigit/dirvish/blob/main/docs/COMPARISON.org#dired-rsync

David Adams added 2 commits July 18, 2022 20:43

bump tools: dired dirvish

3c11e8a

fix(dirvish): include dired-x and newer defaults

97c7735

hlissner mentioned this pull request Jul 22, 2022

Dired fixes and improvements #6585

Closed

David Adams added 2 commits July 24, 2022 13:55

bump for dirvish-quit command

feaea06

rebind quit and attempt centaur-tabs disable

7975c00

proper bump

0311a8e

alexluigit mentioned this pull request Jul 25, 2022

dirivish-toggle-subtree Gives error: "Not a directory" [Bug] alexluigit/dirvish#106

Closed

3 tasks

clean up

b0e775d

thaenalpha pushed a commit to thaenalpha/doom-emacs that referenced this pull request Aug 10, 2022

Merge pull request doomemacs#6568 from Dadams2:master

cf138a4

thaenalpha pushed a commit to thaenalpha/doom-emacs that referenced this pull request Aug 10, 2022

Merge pull request doomemacs#6568 from Dadams2:master

c719c12

thaenalpha added a commit to thaenalpha/doom-emacs that referenced this pull request Aug 10, 2022

Merge pull request doomemacs#6568 from Dadams2:master

b5e06f7

alexluigit mentioned this pull request Sep 8, 2022

feat(dired): restructure the module based on dirvish #6760

Closed

7 tasks

Dadams2 closed this Sep 14, 2022

akhil3417 mentioned this pull request Jul 15, 2023

feat!(dired): use dirvish by default akhil3417/doomemacsonsteroids#10

Merged

akhil3417 mentioned this pull request Sep 14, 2023

refractor!(dired): update module akhil3417/doomemacsonsteroids#35

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dirvish): include dired-x and newer defaults #6568

fix(dirvish): include dired-x and newer defaults #6568

Dadams2 commented Jul 18, 2022 •

edited

Loading

alexluigit commented Jul 19, 2022

teehemkay commented Jul 20, 2022 •

edited

Loading

alexluigit commented Jul 21, 2022 •

edited

Loading

Dadams2 commented Jul 24, 2022 •

edited

Loading

alexluigit commented Jul 24, 2022 •

edited

Loading

Dadams2 commented Jul 24, 2022

alexluigit commented Jul 24, 2022 •

edited

Loading

smallstepman commented Jul 26, 2022 •

edited

Loading

Dadams2 commented Jul 27, 2022

Dadams2 commented Jul 27, 2022

Dadams2 commented Aug 11, 2022

alexluigit commented Aug 13, 2022

Dadams2 commented Sep 14, 2022

fix(dirvish): include dired-x and newer defaults #6568

fix(dirvish): include dired-x and newer defaults #6568

Conversation

Dadams2 commented Jul 18, 2022 • edited Loading

alexluigit commented Jul 19, 2022

teehemkay commented Jul 20, 2022 • edited Loading

alexluigit commented Jul 21, 2022 • edited Loading

Dadams2 commented Jul 24, 2022 • edited Loading

alexluigit commented Jul 24, 2022 • edited Loading

Dadams2 commented Jul 24, 2022

alexluigit commented Jul 24, 2022 • edited Loading

smallstepman commented Jul 26, 2022 • edited Loading

Dadams2 commented Jul 27, 2022

Dadams2 commented Jul 27, 2022

Dadams2 commented Aug 11, 2022

alexluigit commented Aug 13, 2022

Dadams2 commented Sep 14, 2022

Dadams2 commented Jul 18, 2022 •

edited

Loading

teehemkay commented Jul 20, 2022 •

edited

Loading

alexluigit commented Jul 21, 2022 •

edited

Loading

Dadams2 commented Jul 24, 2022 •

edited

Loading

alexluigit commented Jul 24, 2022 •

edited

Loading

alexluigit commented Jul 24, 2022 •

edited

Loading

smallstepman commented Jul 26, 2022 •

edited

Loading