Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a vcpkg declarative configuration declaring a single git registry and baseline, and updates the manifest overrides to pin Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR validates the EASTL 3.27.01 dependency configuration from an upstream vcpkg branch. The vcpkg-configuration.json file configures vcpkg to use a custom registry (alandtse/vcpkg) for obtaining EASTL version 3.27.01, which appears to address known EASTL compatibility issues with CMake 4.0+.
Key Changes:
- No actual code changes detected - the vcpkg-configuration.json file content appears identical to the existing version
- The configuration specifies EASTL 3.27.01 from a custom vcpkg registry branch maintained by alandtse (a known contributor who maintains hlslkit used in this project)
- Both the default Microsoft vcpkg registry and the custom alandtse registry use the same baseline commit hash
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
vcpkg-configuration.json (1)
1-16: Consider refining the PR title per coding guidelines.The PR title follows conventional commits but could be improved:
- Current (56 chars):
test: validate EASTL 3.27.01 from upstream vcpkg branch- Suggested (47 chars):
test: validate eastl 3.27.01 from vcpkg forkChanges:
- Lowercase "eastl" per guidelines
- Removed "upstream" and shortened "vcpkg branch" to "vcpkg fork" to stay under 50 chars
Also, if this PR addresses a specific issue, consider adding "Fixes #" or "Related to #" to the PR description.
As per coding guidelines, conventional commit titles should be lowercase and under 50 characters.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
vcpkg-configuration.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*
⚙️ CodeRabbit configuration file
**/*: When reviewing PRs, please provide suggestions for:
Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
if the existing title does not describe the code changes):
Format: type(scope): description
Length: 50 characters limit for title, 72 for body
Style: lowercase description, no ending period
Examples:
- feat(vr): add cross-eye sampling
- fix(water): resolve flowmap bug
- docs: update shader documentation
Issue References (if PR fixes bugs or implements features):
Suggest adding appropriate GitHub keywords:Otherwise, use your standard review approach focusing on code quality.
Files:
vcpkg-configuration.json
🧠 Learnings (1)
📓 Common learnings
Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build plugin and addons
|
✅ A pre-release build is available for this PR: |
alandtse
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
vcpkg.json (1)
39-42: Consider shortening the PR title to meet the 50-character limit.The PR title "test: validate EASTL 3.27.01 from upstream vcpkg branch" is 56 characters, exceeding the 50-character limit specified in the coding guidelines.
Suggested alternatives:
- "test: validate EASTL 3.27.01 from vcpkg" (43 characters)
- "test: validate EASTL 3.27.01 upstream" (39 characters)
As per coding guidelines.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
vcpkg.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*
⚙️ CodeRabbit configuration file
**/*: When reviewing PRs, please provide suggestions for:
Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
if the existing title does not describe the code changes):
Format: type(scope): description
Length: 50 characters limit for title, 72 for body
Style: lowercase description, no ending period
Examples:
- feat(vr): add cross-eye sampling
- fix(water): resolve flowmap bug
- docs: update shader documentation
Issue References (if PR fixes bugs or implements features):
Suggest adding appropriate GitHub keywords:Otherwise, use your standard review approach focusing on code quality.
Files:
vcpkg.json
🧠 Learnings (1)
📓 Common learnings
Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build plugin and addons
🔇 Additional comments (1)
vcpkg.json (1)
39-42: LGTM! EASTL version override is correctly formatted.The EASTL 3.27.01 release exists and includes minor fixes for C++14 compatibility. The override syntax matches the existing patterns in this file.
Since this PR mentions testing from an upstream vcpkg branch (per the AI summary, vcpkg-configuration.json defines a custom registry), ensure that the vcpkg-configuration.json properly references the registry containing this version.
|
microsoft/vcpkg#49228 to swap back to vcpkg registry. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @vcpkg-configuration.json:
- Around line 1-11: The vcpkg registry block in vcpkg-configuration.json
contains an invalid baseline commit ("0793c0ffb30cccd574f7804ac367d028c39b72ec")
for the git registry pointing at "https://github.com/alandtse/vcpkg" which will
break package resolution; either replace the "baseline" value with a real commit
SHA from that fork that includes the "eastl-3.27.01" reference branch, or remove
the entire registry object (the entry with "kind": "git", "repository",
"baseline", "reference", "packages") so vcpkg falls back to default registries;
also verify or update the upstream PR reference (microsoft/vcpkg#49228)
mentioned in your change notes to ensure it exists and corresponds to the chosen
baseline/reference.
🧹 Nitpick comments (1)
vcpkg.json (1)
60-60: Consider updating builtin-baseline to match vcpkg-configuration.json.The
builtin-baselinehere (a62ce77d56ee07513b4b67de1ec2daeaebfae51a) differs from the baseline in vcpkg-configuration.json (0793c0ffb30cccd574f7804ac367d028c39b72ec). While the custom registry in vcpkg-configuration.json takes precedence foreastlandeabase, maintaining different baselines may cause confusion.Consider whether the builtin-baseline should be updated to match, or document why they differ.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
vcpkg-configuration.jsonvcpkg.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*
⚙️ CodeRabbit configuration file
**/*: When reviewing PRs, please provide suggestions for:
Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
if the existing title does not describe the code changes):
Format: type(scope): description
Length: 50 characters limit for title, 72 for body
Style: lowercase description, no ending period
Examples:
- feat(vr): add cross-eye sampling
- fix(water): resolve flowmap bug
- docs: update shader documentation
Issue References (if PR fixes bugs or implements features):
Suggest adding appropriate GitHub keywords:Otherwise, use your standard review approach focusing on code quality.
Files:
vcpkg.jsonvcpkg-configuration.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build plugin and addons
🔇 Additional comments (1)
vcpkg.json (1)
39-46: Verify eabase is an intentional transitive dependency; consider explicitly listing it for clarity.The overrides for
eabase(2025-08-03) andeastl(3.27.01) are correctly configured. However,eabaseappears only in the overrides section, not in the main dependencies array, indicating it's a transitive dependency ofeastl.The custom vcpkg registry is properly configured in vcpkg-configuration.json with explicit reference to
eastl-3.27.01and both packages listed as available, confirming version availability. For improved clarity and maintainability, consider explicitly addingeabaseto the main dependencies array if it's a critical requirement, rather than relying solely on the transitive dependency chain.
| { | ||
| "registries": [ | ||
| { | ||
| "kind": "git", | ||
| "repository": "https://github.com/alandtse/vcpkg", | ||
| "baseline": "0793c0ffb30cccd574f7804ac367d028c39b72ec", | ||
| "reference": "eastl-3.27.01", | ||
| "packages": ["eastl", "eabase"] | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
microsoft vcpkg pull request 49228 eastl status
💡 Result:
Do you mean the GitHub pull request microsoft/vcpkg#49228 that updates the eastl port? If so I can look it up — confirm and I’ll fetch the current status.
🏁 Script executed:
#!/bin/bash
# Verify the custom registry configuration exists and is accessible
# Check if the fork repository is reachable
echo "=== Checking fork repository ==="
git ls-remote https://github.com/alandtse/vcpkg HEAD 2>&1 | head -5
# Check if the baseline commit exists
echo -e "\n=== Checking baseline commit 0793c0ffb30cccd574f7804ac367d028c39b72ec ==="
git ls-remote https://github.com/alandtse/vcpkg 0793c0ffb30cccd574f7804ac367d028c39b72ec
# Check if the reference branch eastl-3.27.01 exists
echo -e "\n=== Checking reference branch eastl-3.27.01 ==="
git ls-remote --heads https://github.com/alandtse/vcpkg eastl-3.27.01
# Also check tags in case it's a tag instead of a branch
echo -e "\n=== Checking if eastl-3.27.01 is a tag ==="
git ls-remote --tags https://github.com/alandtse/vcpkg eastl-3.27.01Repository: doodlum/skyrim-community-shaders
Length of output: 388
🌐 Web query:
site:github.com microsoft/vcpkg pull 49228
💡 Result:
I searched microsoft/vcpkg but couldn't find a pull request numbered 49228. The repository's PR index and main repo are here for you to check directly: [1][2].
Sources:
[1] microsoft/vcpkg — Pull requests list.
[2] microsoft/vcpkg — repository home.
🏁 Script executed:
#!/bin/bash
# Get more details about what's in the fork
echo "=== Recent commits in fork ==="
git ls-remote https://github.com/alandtse/vcpkg refs/heads/eastl-3.27.01
echo -e "\n=== Checking main branch of fork ==="
git ls-remote https://github.com/alandtse/vcpkg main masterRepository: doodlum/skyrim-community-shaders
Length of output: 269
Fix invalid baseline commit in vcpkg registry configuration.
The baseline commit 0793c0ffb30cccd574f7804ac367d028c39b72ec does not exist in the fork repository, which will cause the registry to fail. While the reference branch eastl-3.27.01 exists in the fork, the baseline must point to a valid commit for vcpkg to resolve packages from this registry.
Before merging, either:
- Update the baseline to a valid commit from the fork repository, or
- Remove this custom registry configuration
Additionally, the upstream PR reference (microsoft/vcpkg#49228) could not be located and should be verified.
🤖 Prompt for AI Agents
In @vcpkg-configuration.json around lines 1 - 11, The vcpkg registry block in
vcpkg-configuration.json contains an invalid baseline commit
("0793c0ffb30cccd574f7804ac367d028c39b72ec") for the git registry pointing at
"https://github.com/alandtse/vcpkg" which will break package resolution; either
replace the "baseline" value with a real commit SHA from that fork that includes
the "eastl-3.27.01" reference branch, or remove the entire registry object (the
entry with "kind": "git", "repository", "baseline", "reference", "packages") so
vcpkg falls back to default registries; also verify or update the upstream PR
reference (microsoft/vcpkg#49228) mentioned in your change notes to ensure it
exists and corresponds to the chosen baseline/reference.
* build: bump eastl to 3.27.01 (doodlum#1673) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> * fix(grass collision): ignore hkpListShape (doodlum#1661) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore(upscaling): update SDKs (doodlum#1684) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore(terrain shadows): modernize (doodlum#1678) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add user wiki link to readme (doodlum#1689) * feat(LLF): add debug overlay in llf visualiser (doodlum#1666) * feat: linear lighting (doodlum#1359) Co-authored-by: jiayev <jiayev@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: weather and imagespace editor (doodlum#1630) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix(ui): load previously selected theme on startup (doodlum#1664) --------- Co-authored-by: Alan Tse <alandtse@users.noreply.github.com> Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: jiayev <l936249247@hotmail.com> Co-authored-by: jiayev <jiayev@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2 participants
DO NOT MERGE
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.