Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Traditional Chinese translation #133

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Add Traditional Chinese translation #133

merged 3 commits into from
Feb 28, 2018

Conversation

kevingo
Copy link
Contributor

@kevingo kevingo commented Feb 14, 2018 •
edited
Loading

Hi @donnemartin , I've already finished the Traditional Chinese translation which the issue goes here issue. I also add the link by updating the table of content in README.md. Please helps check.

Thanks.

@donnemartin
Copy link
Owner

Hi @kevingo, awesome!

Can a native speaker review this? Thank you!

@kevingo
Copy link
Contributor Author

kevingo commented Feb 15, 2018

Hi @donnemartin, sure! Do you have any idea that who can review it? Or I should find one to do that?

@donnemartin
Copy link
Owner

I'm hoping someone will jump in to help with a review, please feel free to find a reviewer.

@yssource
Copy link

新年快樂, 恭喜發財

@yssource
Copy link

Maybe, I can do something to review the translation, though I'm using the Simple Chinese in our daily life.
By the way, it is the Chinese new year right now. And, Chinese is busy with our holidays in the following week. I would like to wish YOU Happy Chinese New Year, as well.

@kevingo
Copy link
Contributor Author

kevingo commented Feb 15, 2018

@yssource 那真是太感謝了！也祝您新年快樂。

@kevingo
Copy link
Contributor Author

kevingo commented Feb 15, 2018

@donnemartin, thanks to @yssource. He will help to review this PR. :)

@yssource
Copy link

I go through the translation and try to find some of mistakes. But I find the translation is very good and professional.

@kevingo
Copy link
Contributor Author

kevingo commented Feb 15, 2018

@yssource Thanks for your great support. :)

@yssource
Copy link

lang original suggestion example
en links Common system design interview questions, with links to resources on how to solve each.
zh-TW 連結 鏈接 常見的系統設計問題，同時提供如何解決該問題的 連結 鏈接

@yssource
Copy link

yssource commented Feb 15, 2018 •
edited
Loading

I will take more time to learn this project and review the translation. @kevingo It's amazing about your Chinese.
It's time for me going sleep. China has already entered the new year.

@kevingo
Copy link
Contributor Author

kevingo commented Feb 15, 2018

@yssource, that's great. Have nice vacations.

@appleboy
Copy link

@yssource Why change 連結 to 鏈接? I prefer 連結 should be better than 鏈接 for Traditional Chinese.

appleboy
appleboy suggested changes Feb 16, 2018
View reviewed changes
README-zh-TW.md Outdated

### 公司的系統架構

| 公司 | 參考 |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建議 markdown table 可以使用 https://www.tablesgenerator.com/markdown_tables 來產生，方便 review。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝 @appleboy ，剛剛在我自己的 repo 測試了一下：link，看起來還不錯，我會把所有 table 改為此模式

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我把 table 改為使用 markdown table 來產生，請幫忙確認 @appleboy @yssource。Thanks!

@kevingo
Copy link
Contributor Author

kevingo commented Feb 16, 2018 •
edited
Loading

Hi @yssource, I also think 連結 is better than 鏈接 in Traditional Chinese. I prefer to leave it as 連結. Is it ok with you ?

@yssource
Copy link

@appleboy 謝謝你的指正.
@kevingo I think @appleboy is more professional then me about the Traditional Chinese. And he could help you more than I can do.

@kevingo
Copy link
Contributor Author

kevingo commented Feb 17, 2018

@yssource, any comments are welcome and helpful :)

@yssource
Copy link

yssource commented Feb 18, 2018 •
edited
Loading

@kevingo 我才意識到你是來自美麗的台灣. 😊 🤝

@kevingo
Copy link
Contributor Author

kevingo commented Feb 18, 2018

@yssource 哈哈是的，用繁體中文的地方已經不太多了

appleboy
appleboy suggested changes Feb 19, 2018
View reviewed changes
README-zh-TW.md
<br/>
</p>

請參考 [**互動程式語言學習挑戰**](https://github.com/donnemartin/interactive-coding-challenges)，當中還包含了底下的學習單字卡：
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本篇翻譯部分，連結前後方是否空格，這部分需要統一

請參考 https://github.com/sparanoid/chinese-copywriting-guidelines#%E9%8F%88%E6%8E%A5%E4%B9%8B%E9%96%93%E5%A2%9E%E5%8A%A0%E7%A9%BA%E6%A0%BC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appleboy 連結前後已加上空格 ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appleboy @yssource 再請幫忙確認是否有其他問題，感謝！

@appleboy
Copy link

LGTM

@donnemartin
Copy link
Owner

Great work everyone! Is this ready to merge?

@appleboy
Copy link

@donnemartin yes.

@kevingo
Copy link
Contributor Author

kevingo commented Feb 27, 2018

@donnemartin Please help. Thank you :)

@donnemartin donnemartin merged commit c3c59c9 into donnemartin:master Feb 28, 2018
@donnemartin
Copy link
Owner

@kevingo @yssource @appleboy thank you!

godelian added a commit to godelian/system-design-primer that referenced this pull request Oct 9, 2019
@godelian
Update from original (#1)
ef29857 
* Add license disclaimer (donnemartin#76)

Clearly denote the repository license is from me, not my employer (Facebook).

* Fix asynchronism link in Mint README (donnemartin#69)

* Fix lowercase typo in Layer 7 load balancing title (donnemartin#74)

* Fix donnemartin#79: Inaccuracy in Twitter timeline and search example (donnemartin#81)

* Fix typo (donnemartin#75)

* Init spot_size member in parking lot exercise (donnemartin#83)

* Add prev to Node class (donnemartin#82)

For managing an LRU cache, we need to use a doubly linked list for move_to_front() operation.

* Fix reducer argument in pastebin exercise (donnemartin#85)

* Add polish translation link (donnemartin#89)

* Fix typo in denormalization section (donnemartin#95)

* Add policy for adding new blogs to Company engineering blogs section (donnemartin#96)

* Add Russian translation link (donnemartin#91)

* Treat solution subdirectories as containing Python packages (donnemartin#99)

* Add Japanese translation link (donnemartin#101)

* Add traditional Chinese translation link (donnemartin#105)

* Add Italian translation link (donnemartin#106)

* Fix typo: considering to consider in scaling AWS solution (donnemartin#109)

* Add API rate limiter design link (donnemartin#108)

* Add Korean translation link (donnemartin#111)

* Simplify logic for is_ace and is_face_card in deck of cards solution (donnemartin#113)

* Add Persian translation link (donnemartin#115)

* Correct Redis list structure in Twitter solution (donnemartin#116)

* Add Japanese Translation (donnemartin#114)

* Update Japanese translation link (donnemartin#118)

* ja: Fix typo (donnemartin#119)

* Make some minor wording/formatting changes (donnemartin#120)

* add Twitter Handles 3,000 Images Per Second

* Add Netflix in Company Architectures (donnemartin#122)

* Add Vietnamese translation link (donnemartin#128)

* Add Scaling Uber in Company Architecture (donnemartin#123)

* Update master-slave section anchor (donnemartin#129)

* Add Facebook Live Streams (donnemartin#125)

* Update contributing guidelines - PR squash (donnemartin#135)

* Update re:Invent url (donnemartin#137)

* Add Traditional Chinese translation (donnemartin#133)

* zh-TW: Add proper line break to links (donnemartin#139)

* Add Greek translation link (donnemartin#140)

* Convert all .py files to be valid Python (donnemartin#98)

* zh-Hans: Fix typos (donnemartin#141)

* Add Spanish translation link (donnemartin#142)

* Add missing colons to class methods (donnemartin#143)

* Add missing self variables to Deck of Cards solution (donnemartin#145)

* Add deque import to Social Graph solution (donnemartin#147)

* Change LARGE to VehicleSize.LARGE in parking lot solution (donnemartin#146)

* zh-TW: Fix comment format (donnemartin#155)

* Fix coding errors (donnemartin#149)

* Fix dict KeyError (donnemartin#152)

* Fix dict KeyError (donnemartin#153)

* Adding missing self variable (donnemartin#158)

* Add missing enum imports (donnemartin#157)

* Change variable seller to category in Mint solution (donnemartin#159)

* zh-Hans: Fix typo (donnemartin#161)

* Replace broken SQL tuning links (donnemartin#163)

* zh-Hans: Fix PostgreSQL typo (donnemartin#166)

* Fix donnemartin#148: Add State(Enum) to social_graph_snippets.py (donnemartin#167)

* ja: Swap VARCHAR and CHAR translation error (donnemartin#169)

* Add Arabic translation link (donnemartin#177)

* Add newlines - PEP8 style (donnemartin#173)

* zh-TW: Improve translations (donnemartin#176)

* Fix typo in LRU cache solution (donnemartin#182)

* Fix broken links (donnemartin#180)

* Add German translation link (donnemartin#188)

* Add Thai translation link (donnemartin#190)

* Fix broken URL (donnemartin#194)

* Fix error in Twitter timeline solution (donnemartin#196)

* Fix wording in call center solution (donnemartin#197)

* Resolve donnemartin#195: Fix broken GitHub URLs (donnemartin#199)

* zh-Hans: Fix typo: 'Twitter' (donnemartin#200)

* Update Twitter/Facebook exercise description (donnemartin#202)

* Fix typo in CAP theorem section (donnemartin#205)

* Fix broken links (donnemartin#204)

* Fix donnemartin#126: Update link to Anki decks (donnemartin#206)

* Fix typo in Design Pastebin.com exercise (donnemartin#210)

* zh-Hans: Fix translation (donnemartin#208)

* zh-Hans: Update translation (donnemartin#212)

* zh-Hans: Update translation (donnemartin#209)

* Update Cassandra architecture links (donnemartin#213)

* Update README intro (donnemartin#216)

* Resolve donnemartin#214: Add reference links to message queues section (donnemartin#218)

* Update Scalability for Dummies link (donnemartin#224)

* ja: Fix typo (donnemartin#226)

* zh-TW: Update index anchors (donnemartin#227)

* Add Link: A 360 Degree View Of The Entire Netflix Stack (donnemartin#229)

* Fix donnemartin#228: Address mutex latency discrepancy (donnemartin#233)

* Add Bengali translation link (donnemartin#242)

* Add missing word in cache write through discussion (donnemartin#245)

* zh-Hans: Fix typo (donnemartin#246)

* Fix grammar in document store section (donnemartin#247)

* Fix typo in Twitter timeline and search solution (donnemartin#251)

* Update document-store to document store (donnemartin#255)

* Enable Python syntax highlighting in Pastebin sample code (donnemartin#257)

* Fix broken SQL link in Scaling AWS exercise (donnemartin#258)

Fix broken SQL link in Scaling AWS exercise

* Update HDFS design link to the latest version (donnemartin#275)

* Enable syntax highlighting in all python code snippets (donnemartin#268)

* Translate language list (donnemartin#252)

* Add Ebook generation script (donnemartin#207)

* Add availability in numbers section (donnemartin#237)

* Update language lists in translations (donnemartin#280)

* Add Hebrew translation link (donnemartin#286)

* zh-Hans: Translate Pastebin solution (donnemartin#273)

* ja: Fix typo of Big-O notation in KVS section (donnemartin#292)

* JA: Fix mistranslation in Horizontal scaling section

- The Japanese translation is ambiguous about “vertical scaling” means scaling out or scaling up.
- The word “expensive” is missing in the Japanese translation.

* JA: Fix mistranslation in Reverse proxy (web server) section

- Fix mistranslation of parallel structure. (not information/blacklist/limit, but hide/blacklist/limit)

* ja: Fix mistranslation in "Horizontal scaling"

* JA: Fix mistranslation in Weak consistency section (donnemartin#299)

* JA: Fix mistranslation in Push CDNs section (donnemartin#300)

* JA: Fix mistranslation in Federation section (donnemartin#303)

* ja: Fix translation in "Anki flashcards" (donnemartin#306)

* ja: Fix translation in “Disadvantage(s): load balancer” (donnemartin#307)

* ja: Fix translation in Service Discovery section (donnemartin#308)
Godfrey-Ndungu pushed a commit to Godfrey-Ndungu/system-design-primer that referenced this pull request Jun 20, 2023
@kevingo @donnemartin
Add Traditional Chinese translation (donnemartin#133)
9712a12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnemartin donnemartin donnemartin approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
help wanted needs-review translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevingo @donnemartin @yssource @appleboy