Merge pull request #8 from donmo-roundup/improve-order-lifecycles-han…

…dling Improve order lifecycles handling
donmo-roundup · Jun 22, 2023 · b5947a1 · b5947a1
2 parents 714473b + c3a4395
commit b5947a1
Show file tree

Hide file tree

Showing 8 changed files with 46 additions and 39 deletions.
diff --git a/Observer/ConfirmDonationOnOrderComplete.php b/Observer/ConfirmDonationOnOrderComplete.php
@@ -37,9 +37,12 @@ public function execute(Observer $observer)
     {
         try {
             $order = $observer->getEvent()->getOrder();
+            $donationAmount = (float) $order->getDonmodonation();
+
             if ($order->getState() == 'complete') {
-                if ($order->getDonmodonation() > 0) {
+                if ($donationAmount > 0) {
 
+                    $orderId = $order->getId();
                     $quoteId = $order->getQuoteId();
                     $maskedId = $this->quoteIdToMaskedQuoteId->execute($quoteId);
 
@@ -48,11 +51,11 @@ public function execute(Observer $observer)
                     $this->donationResource->load($donationModel, $maskedId, 'masked_quote_id');
 
                     $donationModel
-                        ->setStatus(DonationModel::STATUS_CONFIRMED);
+                        ->setStatus(DonationModel::STATUS_CONFIRMED)
+                        ->setOrderId($orderId);
                     $this->donationResource->save($donationModel);
                 }
 
-                $this->donationResource->save($donationModel);
             }
         } catch (\Exception $exception) {
             $this->logger->error("Donmo ConfirmDonationOnOrderComplete Observer error:\n" . $exception);

diff --git a/Observer/CreateDonation.php b/Observer/CreateDonation.php
@@ -8,8 +8,6 @@
 
 use Donmo\Roundup\Model\Config as DonmoConfig;
 
-use Magento\Framework\Intl\DateTimeFactory;
-
 
 use Donmo\Roundup\Model\Donmo\DonationFactory;
 use Donmo\Roundup\Model\Donmo\Donation as DonationModel;
@@ -24,23 +22,20 @@ class CreateDonation implements ObserverInterface
     private DonationFactory $donationFactory;
     private DonationResource $donationResource;
 
-    private DateTimeFactory $dateTimeFactory;
 
     private Logger $logger;
     private QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteId;
 
     public function __construct(
         DonationFactory  $donationFactory,
         DonationResource $donationResource,
-        DateTimeFactory $dateTimeFactory,
         Logger $logger,
         DonmoConfig $config,
         QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteId
     )
     {
         $this->donationFactory = $donationFactory;
         $this->donationResource = $donationResource;
-        $this->dateTimeFactory = $dateTimeFactory;
         $this->logger = $logger;
         $this->donmoConfig = $config;
         $this->quoteIdToMaskedQuoteId = $quoteIdToMaskedQuoteId;
@@ -49,29 +44,23 @@ public function __construct(
 
     public function execute(Observer $observer)
     {
+        $order = $observer->getEvent()->getOrder();
+
+        $donationAmount = (float) $order->getDonmodonation();
+
         try {
-            $order = $observer->getEvent()->getOrder();
-            if ($order->getState() == 'new') {
-                if ($order->getDonmodonation() > 0) {
-                    $orderId = $order->getId();
-                    $quoteId = $order->getQuoteId();
-                    $maskedId = $this->quoteIdToMaskedQuoteId->execute($quoteId);
-                    $currentMode = $this->donmoConfig->getCurrentMode();
-                    $createdAt = $this->dateTimeFactory->create(
-                        $order->getCreatedAt(),
-                        new \DateTimeZone('UTC')
-                    );
-
-                    $donationModel = $this->donationFactory->create();
-
-                    $donationModel
-                        ->setMaskedQuoteId($maskedId)
-                        ->setOrderId($orderId)
-                        ->setDonationAmount($order->getDonmodonation())
-                        ->setCreatedAt($createdAt)
-                        ->setStatus(DonationModel::STATUS_PENDING)
-                        ->setMode($currentMode);
-                }
+            if ($donationAmount > 0) {
+                $quoteId = $order->getQuoteId();
+                $maskedId = $this->quoteIdToMaskedQuoteId->execute($quoteId);
+                $currentMode = $this->donmoConfig->getCurrentMode();
+
+                $donationModel = $this->donationFactory->create();
+
+                $donationModel
+                    ->setMaskedQuoteId($maskedId)
+                    ->setDonationAmount($donationAmount)
+                    ->setStatus(DonationModel::STATUS_PENDING)
+                    ->setMode($currentMode);
 
                 $this->donationResource->save($donationModel);
             }

diff --git a/Observer/RemoveDonationWithOrder.php b/Observer/RemoveDonationWithOrder.php
@@ -54,7 +54,9 @@ public function execute(Observer $observer)
                 $newDonationStatus = DonationModel::STATUS_REFUNDED;
             }
 
-            if ($order->getDonmodonation() > 0) {
+            $donationAmount = (float) $order->getDonmodonation();
+
+            if ($donationAmount> 0) {
                 $quoteId = $order->getQuoteId();
                 $maskedId = $this->quoteIdToMaskedQuoteId->execute($quoteId);
 
@@ -65,7 +67,8 @@ public function execute(Observer $observer)
                 if ($donationModel->getData('status') != DonationModel::STATUS_SENT) {
                     $donationModel->setData('status', $newDonationStatus);
                     $this->donationResource->save($donationModel);
-                } // make Delete request to Donmo API for only if donation is already sent
+                }
+                // make Delete request to Donmo API for only if donation is already sent
                 else {
                     $status = $this->apiService->deleteDonation($donationMode, $maskedId);
 

diff --git a/Ui/Component/Listing/Column/Status.php b/Ui/Component/Listing/Column/Status.php
@@ -14,15 +14,22 @@ public function toOptionArray()
         if ($this->options !== null) {
             return $this->options;
         }
-        $this->options[DonationModel::STATUS_CONFIRMED]['label'] = DonationModel::STATUS_CONFIRMED;
-        $this->options[DonationModel::STATUS_CONFIRMED]['value'] = DonationModel::STATUS_CONFIRMED;
 
         $this->options[DonationModel::STATUS_PENDING]['label'] = DonationModel::STATUS_PENDING;
         $this->options[DonationModel::STATUS_PENDING]['value'] = DonationModel::STATUS_PENDING;
 
+        $this->options[DonationModel::STATUS_CONFIRMED]['label'] = DonationModel::STATUS_CONFIRMED;
+        $this->options[DonationModel::STATUS_CONFIRMED]['value'] = DonationModel::STATUS_CONFIRMED;
+
         $this->options[DonationModel::STATUS_DELETED]['label'] = DonationModel::STATUS_DELETED;
         $this->options[DonationModel::STATUS_DELETED]['value'] = DonationModel::STATUS_DELETED;
 
+        $this->options[DonationModel::STATUS_REFUNDED]['label'] = DonationModel::STATUS_REFUNDED;
+        $this->options[DonationModel::STATUS_REFUNDED]['value'] = DonationModel::STATUS_REFUNDED;
+
+        $this->options[DonationModel::STATUS_SENT]['label'] = DonationModel::STATUS_SENT;
+        $this->options[DonationModel::STATUS_SENT]['value'] = DonationModel::STATUS_SENT;
+
         return $this->options;
     }
 }

diff --git a/etc/db_schema.xml b/etc/db_schema.xml
@@ -20,9 +20,9 @@
         <column xsi:type="int" name="order_id" padding="10" unsigned="true" nullable="true" identity="false"
                 comment="Order Id"/>
 
-        <column xsi:type="timestamp" name="created_at" on_update="false" nullable="true" comment="Created At"/>
+        <column xsi:type="timestamp" name="created_at" on_update="false" nullable="true" comment="Created At" default="CURRENT_TIMESTAMP"/>
 
-        <column xsi:type="timestamp" name="updated_at" on_update="false" nullable="true" comment="Updated At"/>
+        <column xsi:type="timestamp" name="updated_at" on_update="false" nullable="true" comment="Updated At" default="CURRENT_TIMESTAMP"/>
 
 
         <constraint xsi:type="primary" referenceId="PRIMARY">
@@ -31,6 +31,8 @@
 
         <constraint xsi:type="unique" referenceId="DONMO_DONATION_MASKED_QUOTE_ID">
             <column name="masked_quote_id"/>
+            <column name="mode"/>
+            <column name="status"/>
         </constraint>
 
         <constraint xsi:type="foreign" referenceId="DONMO_DONATION_MASKED_QUOTE_ID_QUOTE_ID_MASK_MASKED_ID" table="donmo_donation"

diff --git a/etc/events.xml b/etc/events.xml
@@ -14,11 +14,13 @@
     </event>
 
     <!--  Create donation on order success  -->
-    <event name="sales_order_save_after">
+    <event name="sales_order_place_after">
         <observer name="donmo_create_donation_observer" instance="Donmo\Roundup\Observer\CreateDonation" />
-        <observer name="donmo_confirm_donation_observer" instance="Donmo\Roundup\Observer\ConfirmDonationOnOrderComplete" />
     </event>
 
+    <event name="sales_order_save_after">
+        <observer name="donmo_confirm_donation_observer" instance="Donmo\Roundup\Observer\ConfirmDonationOnOrderComplete" />
+    </event>
 
     <!--  Remove donation on order cancellation  -->
     <event name="order_cancel_after">

diff --git a/lib/ApiService.php b/lib/ApiService.php
@@ -71,6 +71,7 @@ public function deleteDonation($donationMode, $id) {
                 $this->logger->error("Unsuccessful Delete Donation API request: \n" . $body);
             }
 
+            return $status;
     }
 
 }
diff --git a/view/adminhtml/ui_component/donmo_report.xml b/view/adminhtml/ui_component/donmo_report.xml
@@ -43,7 +43,7 @@
                     <item name="config" xsi:type="array">
                         <item name="applied" xsi:type="array">
                             <item name="mode" xsi:type="string">live</item>
-                            <item name="status" xsi:type="string">PENDING</item>
+                            <item name="status" xsi:type="string">SENT</item>
                         </item>
                     </item>
                 </argument>