New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(view/lights): for spotlights, restore parent on its target #1491

Open

divyun wants to merge 1 commit into donmccurdy:main from divyun:fix/light-updates

divyun commented Aug 26, 2024

Resolves #1490

Target is added as a child to light.

glTF-Transform/packages/view/src/subjects/LightSubject.ts

Line 50 in 23e2bc6

value.add(value.target);

But when the lights are cloned here

glTF-Transform/packages/view/src/pools/SingleUserPool.ts

Line 29 in 23e2bc6

const dstObject = srcObject.clone();

, the corresponding clone in three.js https://github.com/mrdoob/three.js/blob/817a222f2d12baf44a38baf256bc9d4f65d82465/src/lights/SpotLight.js#L61 doesn't add a parent to target.


          fix(view/lights): for spotlights, restore parent on its target

f345bd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet