Skip to content

Commit

Permalink
fix(annotations): Fixed issue when html sanitizer failes for title to…
Browse files Browse the repository at this point in the history
… annotation body, now fallbacks to html escaping title and text, fixes grafana#2563
  • Loading branch information
torkelo authored and Don Hsieh committed Nov 12, 2015
1 parent 9d8ec58 commit 60d380d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,13 @@ panels or rows, fixes #2534
>>>>>>> fix(auth proxy): Fix for server side rendering of panel when using auth proxy, fixes #2568
- [Issue #2490](https://github.com/grafana/grafana/issues/2490). Graphite: Dashboard import was broken in 2.1 and 2.1.1, working now
- [Issue #2565](https://github.com/grafana/grafana/issues/2565). TimePicker: Fix for when you applied custom time range it did not refreh dashboard
<<<<<<< 9d8ec5825aa59a8d30e71063b9a3b5404f305e67
fixes #2565
>>>>>>> fix(TimePicker): Fix for when you applied custom time range it did not refreh dashboard, fixes #2565
=======
- [Issue #2563](https://github.com/grafana/grafana/issues/2563). Annotations: Fixed issue when html sanitizer failes for title to annotation body, now fallbacks to html escaping title and text
now fallbacks to html escaping title and text, fixes #2563
>>>>>>> fix(annotations): Fixed issue when html sanitizer failes for title to annotation body, now fallbacks to html escaping title and text, fixes #2563
** Breaking Changes **
- Notice to makers/users of custom data sources, there is a minor breaking change in 2.2 that
Expand Down
6 changes: 6 additions & 0 deletions public/app/core/directives/annotation_tooltip.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ define([
function ($, _, coreModule) {
'use strict';

<<<<<<< 9d8ec5825aa59a8d30e71063b9a3b5404f305e67:public/app/core/directives/annotation_tooltip.js
coreModule.directive('annotationTooltip', function($sanitize, dashboardSrv, $compile) {
=======
angular
.module('grafana.directives')
.directive('annotationTooltip', function($sanitize, dashboardSrv, $compile) {
>>>>>>> fix(annotations): Fixed issue when html sanitizer failes for title to annotation body, now fallbacks to html escaping title and text, fixes #2563:public/app/directives/annotationTooltip.js

function sanitizeString(str) {
try {
Expand Down
2 changes: 1 addition & 1 deletion public/app/features/annotations/annotationsSrv.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ define([
min: options.time,
max: options.time,
eventType: options.annotation.name,
title: options.title,
title: 'Torkel <[email protected]>',// options.title,
tags: options.tags,
text: options.text,
score: 1
Expand Down

0 comments on commit 60d380d

Please sign in to comment.