Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing the rate doesn't get saved #292

Open
justinbmeyer opened this issue Feb 22, 2017 · 2 comments
Open

changing the rate doesn't get saved #292

justinbmeyer opened this issue Feb 22, 2017 · 2 comments
Assignees
@ilyavf
Labels
bug p1

Comments

@justinbmeyer
Copy link
Contributor

In Feb, if I change the rate, it doesn't get saved between refreshes.

cursor_and_bitcentive
@ilyavf ilyavf self-assigned this Feb 22, 2017
@ilyavf
Copy link
Contributor

ilyavf commented Feb 22, 2017

We are saving on $enter event. Changing this to use $changed event to be consistent with the rest of the app.

@ilyavf
Copy link
Contributor

ilyavf commented Feb 23, 2017

Fixed with PR #293

justinbmeyer added a commit that referenced this issue Feb 23, 2017
@justinbmeyer
Merge pull request #293 from /issues/292/rate-save
90de3fe 
save rate on change (not on enter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilyavf ilyavf

Labels
bug p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinbmeyer @ilyavf