Skip to content

ajout french language #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

ajout french language #561

wants to merge 3 commits into from

Conversation

mgrafr
Copy link

@mgrafr mgrafr commented Dec 25, 2024

language french checked with 'verify_locale_files.py'

@mgrafr
Create fr-fr.json
c937aaf
@mgrafr
Add french language
b4223ad 
modify active_languages.json
add fr-fr.json , checked with verify_locale_files.py
@DaanSelen
Copy link
Collaborator

Hello @mgrafr did you use: #549
Or a completely different French translation?

DaanSelen
DaanSelen requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@DaanSelen DaanSelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/static/locale/active_languages.json Outdated
@@ -4,6 +4,11 @@
"lang_name": "Czech",
"lang_name_localized": "Česky"
},
{
"lang_id": "fr-fr",
"lang_name": "french",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this alphabetical?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And capitalize

alexperreault
alexperreault reviewed Jan 3, 2025
View reviewed changes
src/static/locale/fr-fr.json
"Update Password": "Mettre à jour le mot de passe",
"Multi-Factor Authentication \\(MFA\\)": "Authentification multifacteur \\(MFA\\)",
"Reset": "Réinitialiser",
"Setup": "nstallation",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo
"Installation"

@alexperreault
Copy link
Contributor

Hello @mgrafr did you use: #549 Or a completely different French translation?

Seems to be different from mine (#549), plus this is Fr-fr, I did Fr-CA

@DaanSelen
Copy link
Collaborator

Hello @mgrafr did you use: #549 Or a completely different French translation?

Seems to be different from mine (#549), plus this is Fr-fr, I did Fr-CA

Thanks, We'll keep that in mind

@mgrafr
Copy link
Author

mgrafr commented Jan 3, 2025

Good morning
I discovered Alexandre Perreault's PR only after creating mine.
I carried out the translation using the terms that I wanted to appear in the application also apart from some very English that we use in France (QR code for ca and QR code for fr, for example the differences should be minimal.
So just call the fr-CA translation fr.json (like for uk.json) and it will be the translation for the French language.

@DaanSelen
Copy link
Collaborator

Good morning I discovered Alexandre Perreault's PR only after creating mine. I carried out the translation using the terms that I wanted to appear in the application also apart from some very English that we use in France (QR code for ca and QR code for fr, for example the differences should be minimal. So just call the fr-CA translation fr.json (like for uk.json) and it will be the translation for the French language.

Good morning.
Would you be willing to update your branch and look through the changes and give it the general ISO name? If you both agree on that, it has been a long while since I have refreshed my French.

@DaanSelen
Copy link
Collaborator

@mgrafr @alexperreault since you both added french, can we perhaps close this PR and you can together (in this discussion maybe) agree to the state of the French translation?

@alexperreault
Copy link
Contributor

Our translations should be (and seem to be) pretty similar. I don't mind mine becoming the generic french translation.

Waiting on @mgrafr 's opinion

@mgrafr
Copy link
Author

mgrafr commented Jan 8, 2025

everything is settled, @alexperreault's translation becomes the generic French translation

@donaldzou
Copy link
Owner

Will close this now :) Thanks you all for the hard work!

@DaanSelen
Copy link
Collaborator

Will close this now :) Thanks you all for the hard work!

You forgot to close x)

@DaanSelen DaanSelen closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexperreault alexperreault alexperreault left review comments

@DaanSelen DaanSelen DaanSelen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgrafr @DaanSelen @alexperreault @donaldzou