-
-
Notifications
You must be signed in to change notification settings - Fork 297
Big refactor with split of code by functional area #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- dashboard.py (browser endpoints) - wg.py (Wireguard related functions) - db.py (Database related functions) - rest_routes.py (REST call enpoints) Also simplified and reused code wherever possible.
I have forked the project, and I am continuing development at https://github.com/theonlynexus/WGDashboard_2 If and when you have time to pick up development again, I am more than willing to merge the two code-bases again. |
Hi @theonlynexus, are you still willing to contribute? I don't know what is still relevant? |
@DaanSelen If someone has picked up the main repo, and is willing to review and approve pull requests, I would be more than happy to help, in the relatively little time I have. |
I think Donald himself has picked up the main repo. |
@theonlynexus coming back to this, what is halting you from implementing needed features to the current updated repo? Is this PR still relevant? |
I don't have the time anymore
I don't really have a clue. it was very relevant when I asked it to be merged 3 years ago. |
I am closing the PR. |
WARNING: some of the DB fields have been renamed, thus this is a breaking PR
In this PR, the application has been split into:
I also tried to keep it DRY and simplify code wherever possible. 99% of the changes are in the Python files, a few small changes have been done to templates and Javascript files.
In theory performance should also be improved, as the code was simplified. For example, the configuration is read only once, before each request, instead of being reloaded in a number of different methods.