Skip to content

Big refactor with split of code by functional area #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

theonlynexus
Copy link

@theonlynexus theonlynexus commented Jul 20, 2022

WARNING: some of the DB fields have been renamed, thus this is a breaking PR

In this PR, the application has been split into:

  • dashboard.py (browser endpoints)
  • wg.py (Wireguard related functions)
  • db.py (Database related functions)
  • rest_routes.py (REST call endpoints)

I also tried to keep it DRY and simplify code wherever possible. 99% of the changes are in the Python files, a few small changes have been done to templates and Javascript files.

In theory performance should also be improved, as the code was simplified. For example, the configuration is read only once, before each request, instead of being reloaded in a number of different methods.

- dashboard.py (browser endpoints)
- wg.py (Wireguard related functions)
- db.py (Database related functions)
- rest_routes.py (REST call enpoints)

Also simplified and reused code wherever possible.
@theonlynexus theonlynexus changed the title Refactor Refactor with split of code Jul 20, 2022
@theonlynexus theonlynexus changed the title Refactor with split of code Bit befactor with split of code by functional area Jul 20, 2022
@theonlynexus theonlynexus changed the title Bit befactor with split of code by functional area Big refactor with split of code by functional area Jul 21, 2022
@theonlynexus
Copy link
Author

I have forked the project, and I am continuing development at https://github.com/theonlynexus/WGDashboard_2

If and when you have time to pick up development again, I am more than willing to merge the two code-bases again.

@DaanSelen
Copy link
Collaborator

Hi @theonlynexus, are you still willing to contribute? I don't know what is still relevant?

@theonlynexus
Copy link
Author

@DaanSelen
Hi, after 2 very hectic years I have been trying to pick up the project again, so... yes, I am willing to contribute. However I had forked into a completely separate project and I wasn't planning on pushing upstream anymore.

If someone has picked up the main repo, and is willing to review and approve pull requests, I would be more than happy to help, in the relatively little time I have.

@DaanSelen
Copy link
Collaborator

@DaanSelen Hi, after 2 very hectic years I have been trying to pick up the project again, so... yes, I am willing to contribute. However I had forked into a completely separate project and I wasn't planning on pushing upstream anymore.

If someone has picked up the main repo, and is willing to review and approve pull requests, I would be more than happy to help, in the relatively little time I have.

I think Donald himself has picked up the main repo.

@DaanSelen
Copy link
Collaborator

@theonlynexus coming back to this, what is halting you from implementing needed features to the current updated repo? Is this PR still relevant?

@theonlynexus
Copy link
Author

@DaanSelen

what is halting you from implementing needed features to the current updated repo?

I don't have the time anymore

Is this PR still relevant?

I don't really have a clue. it was very relevant when I asked it to be merged 3 years ago.

@theonlynexus
Copy link
Author

I am closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants