fix: require GOOGLE_PUBSUB_VERIFICATION_TOKEN for webhook security#1
Merged
fix: require GOOGLE_PUBSUB_VERIFICATION_TOKEN for webhook security#1
Conversation
Previously, if GOOGLE_PUBSUB_VERIFICATION_TOKEN was not set, the webhook would accept all requests without verification. This change rejects requests when the token is not configured, preventing unauthenticated webhook abuse.
The getProgressMessage function was refactored to use completedThreadIds from state instead of a remainingCount parameter. Updated tests to: - Remove the unused second parameter - Set up completedThreadIds in test state
Changed `prompt: "consent"` to `prompt: "select_account"` in three places: - Main Google OAuth config (auth.ts) - Google account linking (linking/auth-url/route.ts) - Google calendar auth (calendar/auth-url/route.ts) Previously, the consent screen was shown on every login even when no new permissions were requested. Now it only shows when permissions change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if GOOGLE_PUBSUB_VERIFICATION_TOKEN was not set, the webhook
would accept all requests without verification. This change rejects
requests when the token is not configured, preventing unauthenticated
webhook abuse.