fix: completions should only include last argument #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh what the heck happened with the pipeline 👀 Did I mess something up? I am not proficient in Rust at all but it reads like some other package has a flaw in it but chances are I am misinterpreting the logs. Is this something I have to fix in the PR (or even can in the first place)? |
domsleee
force-pushed
the
fix/completions-not-split
branch
from
20b142b
to
3df881f
Compare
domsleee
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Not sure if this is the appropriate fix but it looked like splitting the arg got lost in the recent changes to how files with spaces are handled. The test case fails on current main and works with the change though!
Let me know if I should include any changelog, version bumps or other chores in this as well!