Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functional tests / add functional test for secrets #108

Closed
wants to merge 2 commits into from

Conversation

ddl-ebrown
Copy link
Contributor

@ddl-ebrown ddl-ebrown commented Jul 6, 2023

  • go get github.com/helmfile/helmfile && go mod tidy
a031c46782e6e6c662c2c87c76da9aa62ccabd8e # Original GitHub cert
6938fd4d98bab03faadb97b34396831e3780aea1 # As of 13/01/2022
f879abce0008e4eb126e0097e46620f5aaae26ad # As of 01/07/2023
1c58a3a8518e8759bf075b76b750d4f2df264fcd # As of 01/07/2023

@ddl-ebrown ddl-ebrown force-pushed the DOM-47678-add-functional-secret-tests branch 2 times, most recently from 6940b9e to 7eaed51 Compare July 6, 2023 04:01
 - go get github.com/helmfile/helmfile && go mod tidy

 - manually pin back to 0.26 from 0.27 to avoid build errors:

   * k8s.io/api
   * k8s.io/apimachinery
   * k8s.io/client-go

   See operator-framework/operator-sdk#6396
@ddl-ebrown ddl-ebrown force-pushed the DOM-47678-add-functional-secret-tests branch from 7eaed51 to a799f61 Compare July 6, 2023 04:16
@ddl-ebrown
Copy link
Contributor Author

Functional tests want us to run go mod tidy ... but that bumps some of the k8s libraries and triggers compilation errors.

k8s.io/api v0.26.5 -> v0.27.2
k8s.io/apimachinery v0.26.5 -> v0.27.3
k8s.io/client-go v0.26.5 -> v0.27.2

@ddl-ebrown
Copy link
Contributor Author

ddl-ebrown commented Jul 6, 2023

/functional-test


Launched workflow: Functional tests

@ddl-ebrown
Copy link
Contributor Author

https://github.com/dominodatalab/hephaestus/pull/117/files did a bunch of dep bumping that works now

There was still some intent to add functional tests around secrets, but to do that requires that /functional-test works again -- unfortunately I don't have bandwidth to do this. Repo owners should probably do it

@ddl-ebrown ddl-ebrown closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant