Fix build with FFmpeg 7, C++17, and external libresample and kissfft#53
Open
emilazy wants to merge 5 commits intodominikschnitzer:masterfrom
Open
Fix build with FFmpeg 7, C++17, and external libresample and kissfft#53emilazy wants to merge 5 commits intodominikschnitzer:masterfrom
emilazy wants to merge 5 commits intodominikschnitzer:masterfrom
Conversation
2c7fb9d to
754d5df
Compare
Author
|
Note that the Travis build will probably fail because, uh… well, for one, is Travis CI on GitHub even still a thing? But also Debian’s libresample package is a bit broken currently; cf. minorninth/libresample#8. |
Use GNUInstallDirs, CTest, and FindPkgConfig.
754d5df to
86ed2b8
Compare
This was no longer used.
86ed2b8 to
62f197a
Compare
Collaborator
|
Hey @emilazy, sorry for the late reaction! I finally looked at the commits. Thank you for the work, let's see if we can handle all of it in a single PR! My comments:
It would definitely make sense to switch to GitHub Actions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started just doing a quick FFmpeg 7 patch for Nixpkgs but I might have gone overboard.
I removed support for ancient versions of FFmpeg as it didn’t feel worth it to maintain backwards compatibility.
This does also make an external libresample and kissfft implementation with
.pcfiles a hard requirement; I can change it to fall back to the vendored source if you’d prefer.