Fix normalizeSnapshot when repository path contains special characters#178
Closed
lPernod-sorare wants to merge 2 commits intodominikg:mainfrom
Closed
Fix normalizeSnapshot when repository path contains special characters#178lPernod-sorare wants to merge 2 commits intodominikg:mainfrom
lPernod-sorare wants to merge 2 commits intodominikg:mainfrom
Conversation
Owner
|
Hi, thank you for sending PRs. It would be great if you could give examples of what exactly this fixes. |
Contributor
Author
|
When cloning the repository into a folder that contained a - "baseUrl": "<fixture-dir>/parse/valid/with_extends/paths",
+ "baseUrl": "/Users/loic.pernod/git-workspace/tsconfck/packages/tsconfck/tests/fixtures/parse/valid/with_extends/paths",Investigating more, I found that the fixtureDirRegex was incorrect: {
fixtures: '/Users/loic.pernod/git-workspace/tsconfck/packages/tsconfck/tests/fixtures',
fixtureDirRegex: /[/\\]Users[/\\]loic[/\\].pernod[/\\]git-workspace[/\\]tsconfck[/\\]packages[/\\]tsconfck[/\\]tests[/\\]fixtures/g
}The second replace was matching the |
cf86547 to
8fdc653
Compare
Owner
|
included in #179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.