This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Update addAll() to reflect new behavior #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make addAll() fail on responses other than OK in Firefox < 46 and Chrome < 50. Also, if addAll() had to be fixed even though native exists--polyfill add() method too. More details at w3c/ServiceWorker#823
| @@ -62,6 +81,10 @@ if (!Cache.prototype.addAll) { | |||
| // (don't think this is possible to polyfill due to opaque responses) | |||
| return Promise.all( | |||
| responses.map(function(response, i) { | |||
| if (!response.ok) { | |||
| throw new NetworkError('Incorrect response status'); | |||
| } | |||
There was a problem hiding this comment.
None of the responses should cache if any are !ok, could you check all of them before calling .put?
|
Not sure if Github sends notifications for new commits, so pinging, just in case. |
|
LGTM, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make addAll() fail on responses other than OK in Firefox < 46 and Chrome < 50.
Also, if addAll() had to be fixed even though native exists--polyfill add()
method too. More details at w3c/ServiceWorker#823
Also bumped version to
4.0.0since it's kind of breaking change. Let me know if this PR seems messy for you, because I have a bit of such feeling (e.g. userAgent checks),