Repository navigation
Fix parameter matching to consider location when names collide - #4126
Merged
martincostello merged 2 commits intoAug 26, 2026
Merged
martincostello merged 2 commits into
martincostello merged 2 commits into
Conversation
SingleOrDefault was matching OpenApiOperation metadata parameters by name only, causing InvalidOperationException when two parameters shared a name but differed in location (e.g. [FromRoute] and [FromQuery] both named "id"). Now also matches by ParameterLocation via the existing ParameterLocationMap. When In is not specified in the metadata parameter, name-only matching is preserved for backward compatibility. Fixes domaindrivendev#4123
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4126 +/- ##
==========================================
+ Coverage 95.21% 95.22% +0.01%
==========================================
Files 111 111
Lines 4118 4128 +10
Branches 844 845 +1
==========================================
+ Hits 3921 3931 +10
Misses 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for your contribution @nonsoikem - the changes from this pull request have been published as part of version 10.3.0 📦, which is now available from NuGet.org 🚀 |
This was referenced Oct 7, 2026
Open
Open
Open
This was referenced Oct 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
Fixes #4123
When using
.WithOpenApi()on a minimal API endpoint that has twoparameters sharing the same name but bound to different locations
(e.g.
[FromRoute] int idand[FromQuery(Name = "id")] string queryId),Swagger generation fails with
InvalidOperationException: Sequence contains more than one matching element.Details on the issue fix or feature implementation
The
SingleOrDefaultcall inGenerateOpenApiOperationFromMetadataAsyncwas matching
ApiParameterDescriptionentries by name only. When twoparameters share a name but differ in binding source, this throws.
The fix adds an additional filter: when the metadata
OpenApiParameterhas its
Inproperty set, the candidateApiParameterDescriptionmustalso have a
Sourcethat maps to the sameParameterLocationvia theexisting
ParameterLocationMap. WhenInisnull, the originalname-only matching is preserved for backward compatibility.
Two regression tests are included covering both cases (metadata specifies
In = QueryandIn = Path).