Repository navigation
Add coverage for AddServer across multiple documents - #4115
Merged
martincostello merged 1 commit intoAug 20, 2026
Merged
martincostello merged 1 commit into
martincostello merged 1 commit into
Conversation
GetSwagger_SupportsOption_Servers only generates one document, so nothing pinned that the configured servers reach every document rather than the first one asked for. Add a two-document variant that asserts it for both.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4115 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 111 111
Lines 4115 4115
Branches 843 843
=======================================
Hits 3918 3918
Misses 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 7, 2026
Open
Open
Open
Open
This was referenced Oct 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetSwagger_SupportsOption_Serversgenerates a single document, so nothing currently pins that servers configured throughAddServerreach every document rather than only the first one requested. This adds a two-document variant that asserts it for both.Test only, no source changes.
Swashbuckle.AspNetCore.SwaggerGen.Testpasses on net8.0, net9.0 and net10.0 with 761 tests, 0 failed.I wrote this while looking into #3306 and thought the coverage was worth keeping regardless of where that issue lands; it asserts current behaviour and is not a fix for anything.