Fix null examples being represented as the string null#3788
Merged
martincostello merged 3 commits intodomaindrivendev:masterfrom Feb 14, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3788 +/- ##
==========================================
+ Coverage 94.67% 94.93% +0.25%
==========================================
Files 111 111
Lines 3868 3886 +18
Branches 780 784 +4
==========================================
+ Hits 3662 3689 +27
+ Misses 206 197 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
I think that's basically why I ended up changing the code that caused the bug in the first place. I couldn't get it to work and assumed that it wouldn't matter. |
This was referenced Feb 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3784.
I think I have found another thing derivated from the OpenAPI.NET upgrate from 1.X to 2.X, previously when there was declared the example as null that example could be shown on the OpenApi document. Now I cannot create a JsonNode from "null" string and the JsonNode not being null so the serializer does not serialize it(A minor thing I believe).
I tried creating a JsonNode from null string many ways but I think it's not possible by design JsonObject.Parse("null")
https://github.com/microsoft/OpenAPI.NET/blob/8bec88013cbb0f86f7f43dfdb039ce83bf83beaf/src/Microsoft.OpenApi/Models/OpenApiSchema.cs#L535