Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nullabillity problems with dictionaries #2166

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fixed nullabillity problems with dictionaries #2166

merged 1 commit into from
Mar 2, 2022

Conversation

Eneuman
Copy link
Contributor

@Eneuman Eneuman commented Jul 17, 2021

This PR fixes nullabillity issues with Dictionaries like:

        public Dictionary<string, string>? NullableDictionaryWithNonNullableContent { get; set; }
        public Dictionary<string, string> NonNullableDictionaryWithNonNullableContent { get; set; } = default!;
        public Dictionary<string, string?> NonNullableDictionaryWithNullableContent { get; set; } = default!;
        public Dictionary<string, string?>? NullableDictionaryWithNullableContent { get; set; }

Fixes #1849

@Eneuman
Copy link
Contributor Author

Eneuman commented Dec 31, 2021

@domaindrivendev ping

@Eneuman
Copy link
Contributor Author

Eneuman commented Feb 27, 2022

@domaindrivendev Anything I need to change?

@domaindrivendev domaindrivendev merged commit 43b1b34 into domaindrivendev:master Mar 2, 2022
@manandre manandre mentioned this pull request Mar 14, 2022
Closed
@RouR RouR mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect spec for dictionary of nullable values, ie Dictionary<string,decimal?>
2 participants
@Eneuman @domaindrivendev